In T260860#6633233, @Gilles wrote:Not a performance concern, but I notice that the settings page is a navigation dead end. Once you get to it, there is no link back to the Special:GlobalWatchlist page, you're forced to use user history. And once you save changes, there's no link to either Special:GlobalWatchlist or Special:GlobalWatchlistSettings in its default state.
Refreshing the page at that stage doesn't work, you get stuck with seeing this:
I think that the experience of the settings page should match Special:Preferences. After saving your changes, you should still see the form. And there needs to be a button to go back to Special:GlobalWatchlist.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
@Gilles I would prefer not to match Special:Preferences, because the settings special page is implemented very differently from core's preferences.
I was thinking:
- Add a back button next to "Save settings" for before the user saves
- Add a link back to the success message
Thoughts?
Comment Actions
You'd need to consult a designer from staff on this, this is not my speciality. There is a consistency issue here, we can't have every extension have a custom settings page that behaves completely differently than the wiki's or other extensions.
Comment Actions
If the preferences page is extensible (via a hook, maybe?), I think it would make a lot more sense to have these settings added to the "Watchlist" tab there rather than having a dedicated new page.
Comment Actions
In the current user script implementation, there is a button at the top to go back, and when you save you are automatically redirected to the global watchlist
I understand not wanting to deviate from other preferences forms though.
I know @IKhitron has been using the user script and has already tested the extension on beta - what do you think about how to navigate back?
It could be added to the normal preferences, but I couldn't figure out how to give the need for users to be able to add new rows for sites (and I think some other issues I ran into) so we opted for a dedicated special page.
Comment Actions
I can only test so many functionality, because I have no multiple watched pages on beta wikis, of course. I did find many problems and intended to talk with you about them this evening, but as I can see, you've filed tasks for all of them today. For your question, I expected to see autoredirect to Special:GWL as in the script, and was surprised there wasn't. If it was my call, I would have four buttons at the bottom of the settings page: "Save", "Save and go back to the GWL", "Clear", "Clear and go back to the GWL".
Comment Actions
What exactly would "Clear" and "Clear and go back to the [global watchlist]" do - cancel the changes made? Or reset to the default entirely?
Comment Actions
Change 646769 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add a way to return to Special:GlobalWatchlist after saving settings
Comment Actions
Change 646770 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add cancel button to Special:GlobalWatchlistSettings
Comment Actions
Using the existing cancel functionality of HTMLForm for the button to cancel and go back to Special:GlobalWatchlist
Comment Actions
Change 646769 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Add a way to return to Special:GlobalWatchlist after saving settings
Comment Actions
Change 646770 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Add cancel button to Special:GlobalWatchlistSettings
Comment Actions
What do you mean? After you save the settings, there should be a link back, and if you hit cancel, it should take you back immediately. Its not very helpful to just say "it doesn't work properly" without explaining how - please provide steps to reproduce.
Comment Actions
For example.
- Open GlobalWatchlist.
- Click Settings.
- Wait a second to load.
- Click Cancel.
Expected:
Return back.
Got:
Go to GlobalWatchlist.
That is, I'm not going back to where I was, I open the GW from scratch.
Comment Actions
This is the intended behavior, we don't have a way to track what exactly your prior URL was, you are redirected back to Special:GlobalWatchlist and thats its. I realize its frustrating if you use a different language for Special:GlobalWatchlist than you do for the rest of the wiki, and will try to address that, but *this task* is resolved as intended. (For clarity if one doesn't check the urls manually, the first Special:GlobalWatchlist link has ?uselang=he and the second doesn't)