Page MenuHomePhabricator

Add a way to get back to Special:GlobalWatchlist from Special:GlobalWatchlistSettings
Closed, ResolvedPublic3 Estimated Story Points

Description

Not a performance concern, but I notice that the settings page is a navigation dead end. Once you get to it, there is no link back to the Special:GlobalWatchlist page, you're forced to use user history. And once you save changes, there's no link to either Special:GlobalWatchlist or Special:GlobalWatchlistSettings in its default state.

Refreshing the page at that stage doesn't work, you get stuck with seeing this:

Screenshot 2020-11-19 at 11.49.41.png (213×380 px, 16 KB)

I think that the experience of the settings page should match Special:Preferences. After saving your changes, you should still see the form. And there needs to be a button to go back to Special:GlobalWatchlist.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 set the point value for this task to 3.

@Gilles I would prefer not to match Special:Preferences, because the settings special page is implemented very differently from core's preferences.
I was thinking:

  • Add a back button next to "Save settings" for before the user saves
  • Add a link back to the success message

Thoughts?

You'd need to consult a designer from staff on this, this is not my speciality. There is a consistency issue here, we can't have every extension have a custom settings page that behaves completely differently than the wiki's or other extensions.

If the preferences page is extensible (via a hook, maybe?), I think it would make a lot more sense to have these settings added to the "Watchlist" tab there rather than having a dedicated new page.

DannyS712 added a subscriber: IKhitron.

You'd need to consult a designer from staff on this, this is not my speciality. There is a consistency issue here, we can't have every extension have a custom settings page that behaves completely differently than the wiki's or other extensions.

In the current user script implementation, there is a button at the top to go back, and when you save you are automatically redirected to the global watchlist
I understand not wanting to deviate from other preferences forms though.
I know @IKhitron has been using the user script and has already tested the extension on beta - what do you think about how to navigate back?

If the preferences page is extensible (via a hook, maybe?), I think it would make a lot more sense to have these settings added to the "Watchlist" tab there rather than having a dedicated new page.

It could be added to the normal preferences, but I couldn't figure out how to give the need for users to be able to add new rows for sites (and I think some other issues I ran into) so we opted for a dedicated special page.

I can only test so many functionality, because I have no multiple watched pages on beta wikis, of course. I did find many problems and intended to talk with you about them this evening, but as I can see, you've filed tasks for all of them today. For your question, I expected to see autoredirect to Special:GWL as in the script, and was surprised there wasn't. If it was my call, I would have four buttons at the bottom of the settings page: "Save", "Save and go back to the GWL", "Clear", "Clear and go back to the GWL".

I can only test so many functionality, because I have no multiple watched pages on beta wikis, of course. I did find many problems and intended to talk with you about them this evening, but as I can see, you've filed tasks for all of them today. For your question, I expected to see autoredirect to Special:GWL as in the script, and was surprised there wasn't. If it was my call, I would have four buttoms at the bottom of the settings page: "Save", "Save and go back to the GWL", "Clear", "Clear and go back to the GWL".

What exactly would "Clear" and "Clear and go back to the [global watchlist]" do - cancel the changes made? Or reset to the default entirely?

Return to the state you opened the settings page the last time.

Change 646769 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add a way to return to Special:GlobalWatchlist after saving settings

https://gerrit.wikimedia.org/r/646769

Change 646770 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Add cancel button to Special:GlobalWatchlistSettings

https://gerrit.wikimedia.org/r/646770

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.

Using the existing cancel functionality of HTMLForm for the button to cancel and go back to Special:GlobalWatchlist

Change 646769 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Add a way to return to Special:GlobalWatchlist after saving settings

https://gerrit.wikimedia.org/r/646769

Change 646770 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Add cancel button to Special:GlobalWatchlistSettings

https://gerrit.wikimedia.org/r/646770

DannyS712 claimed this task.

Not so important to me, but FYIO, it doesn't work properly.

Not so important to me, but FYIO, it doesn't work properly.

What do you mean? After you save the settings, there should be a link back, and if you hit cancel, it should take you back immediately. Its not very helpful to just say "it doesn't work properly" without explaining how - please provide steps to reproduce.

For example.

  1. Open GlobalWatchlist.
  2. Click Settings.
  3. Wait a second to load.
  4. Click Cancel.

Expected:
Return back.
Got:
Go to GlobalWatchlist.
That is, I'm not going back to where I was, I open the GW from scratch.

For example.

  1. Open GlobalWatchlist.
  2. Click Settings.
  3. Wait a second to load.
  4. Click Cancel.

Expected:
Return back.
Got:
Go to GlobalWatchlist.
That is, I'm not going back to where I was, I open the GW from scratch.

This is the intended behavior, we don't have a way to track what exactly your prior URL was, you are redirected back to Special:GlobalWatchlist and thats its. I realize its frustrating if you use a different language for Special:GlobalWatchlist than you do for the rest of the wiki, and will try to address that, but *this task* is resolved as intended. (For clarity if one doesn't check the urls manually, the first Special:GlobalWatchlist link has ?uselang=he and the second doesn't)

Very well. As I already said, it doesn't metter to me.