Page MenuHomePhabricator
Create Task
Maniphest T268322

SpecialPageExecutor does not return full HTML output of executed page
Closed, ResolvedPublic
Actions

Description

The test helper SpecialPageExecutor::executeSpecialPage() is not returning the full body HTML contrary to its documentation. This makes test that attempts to test special page subtitle contents to fail because the links are nowhere to be found during the test, even though they'll eventually show up in the actual generated HTML

Details

SubjectRepoBranchLines +/-
Add option to allow SpecialPageExecutor return the full HTML contentmediawiki/coreREL1_35+19 -5
Add option to allow SpecialPageExecutor return the full HTML contentmediawiki/coremaster+19 -5
Customize query in gerrit

Event Timeline

Ammarpad created this task.Nov 20 2020, 9:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2020, 9:50 AM
Ammarpad updated the task description. (Show Details)Nov 20 2020, 10:11 AM
gerritbot added a comment.Nov 20 2020, 10:16 AM

Change 642351 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Fix SpecialPageExecutor to actually return full output content

https://gerrit.wikimedia.org/r/642351

gerritbot added a project: Patch-For-Review.Nov 20 2020, 10:16 AM
gerritbot added a comment.Jan 5 2021, 7:04 PM

Change 642351 merged by jenkins-bot:
[mediawiki/core@master] Add option to allow SpecialPageExecutor return the full HTML content

https://gerrit.wikimedia.org/r/642351

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2021, 7:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 5 2021, 8:00 PM
Ammarpad closed this task as Resolved.Jan 6 2021, 7:12 PM
Ammarpad claimed this task.
gerritbot added a comment.Apr 6 2021, 9:05 PM

Change 676963 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_35] Add option to allow SpecialPageExecutor return the full HTML content

https://gerrit.wikimedia.org/r/676963

gerritbot added a project: Patch-For-Review.Apr 6 2021, 9:05 PM
gerritbot added a comment.Apr 6 2021, 9:08 PM

Change 676963 abandoned by Reedy:

[mediawiki/core@REL1_35] Add option to allow SpecialPageExecutor return the full HTML content

Reason:

https://gerrit.wikimedia.org/r/676963

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2021, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL