touch.py ignores valid options with purge
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	JJMC89
	Nov 22 2020, 1:20 AM

Description

Steps to Reproduce:

python3 /shared/pywikibot/core/scripts/touch.py -lang:en -family:wikipedia -purge -forcelinkupdate -cat:'Pages using duplicate arguments in template calls'

Actual Results:

WARNING: forcelinkupdate is not a valid option. It was ignored.
Retrieving 50 pages from wikipedia:en.
WARNING: /shared/pywikipedia/core/pywikibot/bot.py:1154: FutureWarning: pywikibot.bot.OptionHandler.options is deprecated for 1 month and 17 days; use Optionhandler.opt.option attribute or Optionhandler.opt[option] item instead.
  attr = super().__getattribute__(name)

Expected Results:

The script does not ignore valid options

version.py

Pywikibot: [https] r-pywikibot-core.git (67dd6cc, g1, 2020/11/19, 22:20:58, master)
Release version: 5.2.0.dev0
requests version: 2.21.0
  cacerts: /etc/ssl/certs/ca-certificates.crt
    certificate test: ok
Python: 3.5.3 (default, Nov 18 2020, 21:09:16)
[GCC 6.3.0 20170516]
Toolforge hostname: tools-sgebastion-08

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Fix available_options and purge options in touch.py	pywikibot/core	master	+9 -13

Customize query in gerrit

Related Objects

Mentioned In: rPWBCdc593ec6354d: [bugfix] Fix available_options and purge options in touch.py
Mentioned Here: rPWBCc2a4f9efa700: [IMPR] Improvements for OptionHandler
rPWBCae216e179041: [IMPR] Rewrite scripts using new option handler

Event Timeline

JJMC89 created this task.Nov 22 2020, 1:20 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptNov 22 2020, 1:20 AM

Probably related to {c2a4f9efa700} / {ae216e179041}

Xqt claimed this task.Nov 22 2020, 10:47 AM

Xqt triaged this task as Medium priority.Nov 22 2020, 10:51 AM

Change 642809 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix available_options and purge options in touch.py

https://gerrit.wikimedia.org/r/642809

gerritbot added a project: Patch-For-Review.Nov 22 2020, 10:53 AM

Change 642809 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix available_options and purge options in touch.py

https://gerrit.wikimedia.org/r/642809

JJMC89 closed this task as Resolved.Nov 22 2020, 5:20 PM

JJMC89 removed a project: Patch-For-Review.

Xqt mentioned this in rPWBCdc593ec6354d: [bugfix] Fix available_options and purge options in touch.py.Nov 22 2020, 5:45 PM