Page MenuHomePhabricator
Create Task
Maniphest T268528

Remove IPHandler class and 'ipinfo-any' right
Closed, ResolvedPublic
Actions

Description

These aren't being used yet, and they may not be needed when we introduce the new design changes.

We should remove these until we need them, since that time may never come, and they're just creating an extra maintenance burden.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove IPHandler class and 'ipinfo-any' rightmediawiki/extensions/IPInfomaster+3 -297
Customize query in gerrit

Event Timeline

Tchanders created this task.Nov 23 2020, 9:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2020, 9:20 PM
STran added a comment.Nov 23 2020, 9:29 PM

From https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/642483/1 since IPHandler isn't being used right now, if we decide to fix it up, we should add the cache header at that time as well

Tchanders renamed this task from Consider removing IPHandler class and 'ipinfo-any' right to Remove IPHandler class and 'ipinfo-any' right.Jan 21 2021, 1:23 PM
Tchanders added a project: patch-welcome.
Tchanders updated the task description. (Show Details)
AdhamKhatean claimed this task.Jan 21 2021, 3:23 PM
gerritbot added a comment.Jan 21 2021, 3:45 PM

Change 657626 had a related patch set uploaded (by AdhamKhatean; owner: AdhamKhatean):
[mediawiki/extensions/IPInfo@master] Remove IPHandler class and 'ipinfo-any' right

https://gerrit.wikimedia.org/r/657626

gerritbot added a project: Patch-For-Review.Jan 21 2021, 3:45 PM
gerritbot added a comment.Feb 2 2021, 6:26 PM

Change 657626 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Remove IPHandler class and 'ipinfo-any' right

https://gerrit.wikimedia.org/r/657626

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 2 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2021, 7:10 PM
Niharika edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Anti-Harassment-Team.Feb 18 2021, 1:22 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Done: Q3 (2020-2021) on the Anti-Harassment-Team (The Letter Song) board.Feb 18 2021, 2:03 PM
Niharika closed this task as Resolved.Feb 23 2021, 4:49 PM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits