Page MenuHomePhabricator
Create Task
Maniphest T268572

Convert SecurePoll to AbstractSchema
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

In support of T191231: RFC: Abstract schemas and schema changes, SecurePoll should be migrated to using Abstract Schema

Related task T261912: Convert WMF Deployed Extensions to Abstract Schema

Details

SubjectRepoBranchLines +/-
[WIP] Use abstract schemas for SecurePoll tablesmediawiki/extensions/SecurePollmaster+662 -0
Convert to abstract schemamediawiki/extensions/SecurePollmaster+671 -313
Follow-up c391765899bf: Add path to new primary SecurePoll SQL filemediawiki/extensions/WikimediaMaintenancemaster+1 -0
Use abstract schema for some SecurePoll tablesmediawiki/extensions/SecurePollmaster+377 -211
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Nov 23 2020, 11:55 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptNov 23 2020, 11:55 PM
Reedy mentioned this in T261912: Convert WMF Deployed Extensions to Abstract Schema.Nov 24 2020, 12:05 AM
• AMooney moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Nov 24 2020, 2:10 PM
Tchanders added a project: Anti-Harassment.Jan 8 2021, 8:42 PM
Niharika triaged this task as Medium priority.Jan 12 2021, 7:12 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
Niharika updated the task description. (Show Details)Jan 13 2021, 5:32 PM
ARamirez_WMF set the point value for this task to 3.Jan 13 2021, 5:32 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jan 13 2021, 5:53 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
STran claimed this task.Jan 14 2021, 7:46 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Jan 19 2021, 9:48 PM

Change 657196 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] [WIP] Use abstract schemas for SecurePoll tables

https://gerrit.wikimedia.org/r/657196

gerritbot added a project: Patch-For-Review.Jan 19 2021, 9:48 PM
STran mentioned this in T272965: Migrate SecurePoll tables that have parity to AbstractSchema.Jan 26 2021, 11:04 AM
STran added a comment.Jan 26 2021, 11:06 AM

The following tables need to be migrated:

  • securepoll_entity
  • securepoll_msgs
  • securepoll_properties
  • securepoll_elections
  • securepoll_questions
  • securepoll_options
  • securepoll_voters
  • securepoll_votes
  • securepoll_strike
  • spstrike_vote
  • securepoll_lists
  • securepoll_cookie_match

Since this ticket encapsulates all of the tables, I split the work up into smaller tickets. Some of these are easy (T272965: Migrate SecurePoll tables that have parity to AbstractSchema) and some will require extra schema updates (T272966: Migrate SecurePoll tables that need schema changes to AbstractSchema).

STran added subtasks: T272966: Migrate SecurePoll tables that need schema changes to AbstractSchema, T272965: Migrate SecurePoll tables that have parity to AbstractSchema.Jan 26 2021, 5:14 PM
STran moved this task from The Letter Song to Product/Tech backlog on the Anti-Harassment board.
STran edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).
Ladsgroup subscribed.Feb 2 2021, 7:19 PM
gerritbot added a comment.Feb 26 2021, 10:56 PM

Change 667290 had a related patch set uploaded (by Tchanders; owner: STran):
[mediawiki/extensions/SecurePoll@master] Use abstract schema for some SecurePoll tables

https://gerrit.wikimedia.org/r/667290

gerritbot added a comment.Mar 1 2021, 8:34 PM

Change 667290 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use abstract schema for some SecurePoll tables

https://gerrit.wikimedia.org/r/667290

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 9:00 PM
Niharika closed subtask T272965: Migrate SecurePoll tables that have parity to AbstractSchema as Resolved.Mar 4 2021, 4:22 PM
Niharika removed a project: Anti-Harassment.Mar 24 2021, 4:31 PM
Jdforrester-WMF mentioned this in T283844: Some wikis have the SecurePoll extension installed, but not its tables.May 27 2021, 6:05 PM
gerritbot added a comment.May 27 2021, 6:07 PM

Change 696601 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikimediaMaintenance@master] Follow-up c391765899bf: Update path to SecurePoll SQL file

https://gerrit.wikimedia.org/r/696601

gerritbot added a comment.Jun 1 2021, 10:50 PM

Change 696601 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Follow-up c391765899bf: Add path to new primary SecurePoll SQL file

https://gerrit.wikimedia.org/r/696601

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 1 2021, 11:00 PM
Umherirrender added a subtask: T310444: Standardise type for timestamp columns in SecurePoll extension.Jun 12 2022, 8:59 PM
gerritbot added a comment.Jun 14 2022, 8:11 PM

Change 805469 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SecurePoll@master] Convert to abstract schema

https://gerrit.wikimedia.org/r/805469

Umherirrender subscribed.Jun 14 2022, 8:12 PM
gerritbot added a comment.Jul 13 2022, 6:07 PM

Change 805469 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Convert to abstract schema

https://gerrit.wikimedia.org/r/805469

Umherirrender closed this task as Resolved.Jul 13 2022, 6:35 PM
Umherirrender closed subtask T272966: Migrate SecurePoll tables that need schema changes to AbstractSchema as Resolved.
Umherirrender closed subtask T310444: Standardise type for timestamp columns in SecurePoll extension as Resolved.
Umherirrender removed a project: Patch-For-Review.
gerritbot added a comment.Jul 13 2022, 6:37 PM

Change 657196 abandoned by Umherirrender:

[mediawiki/extensions/SecurePoll@master] [WIP] Use abstract schemas for SecurePoll tables

Reason:

Done with Id08cb297d62d4a92442fe16be9d9b5a72be73fac instead

https://gerrit.wikimedia.org/r/657196

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL