skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Nov 24 2020, 4:13 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Ammarpad

Jdlrobson

Description

8KB > 8KB ?

Selenium skins/Vector
Hide Details

04:32:38 > @ selenium-test /workspace/src/skins/Vector
04:32:38 > npm -s run test:size
04:32:38 
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34816 [200]: //load.php?lang=en&modules=skins.vector.styles.legacy
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34818 [200]: //load.php?lang=en&modules=skins.vector.styles
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34820 [200]: //load.php?lang=en&modules=skins.vector.styles.responsive
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34822 [200]: //load.php?lang=en&modules=skins.vector.legacy.js
04:32:41  FAIL  skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.styles.responsive: 553B < maxSize 614B (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.legacy.js: 1.76KB < maxSize 1.8KB (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.styles: 9.05KB < maxSize 9.1KB (gzip)

https://integration.wikimedia.org/ci/job/mediawiki-quibble-selenium-vendor-mysql-php72-docker/5169/console

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Bump the bundlesize of skins.vector.styles and skins.vector.styles	Ammarpad	mediawiki/skins/Vector	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T270883: Bundlesize test should be updated to warn rather than fail
Mentioned Here: T259903: Merge DismissableSiteNotice extension into core

Event Timeline

Ammarpad created this task.Nov 24 2020, 4:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2020, 4:13 AM

This looks strange and is repeatedly happening so it's not one-off

Ammarpad added a subscriber: Jdlrobson.Nov 24 2020, 4:20 AM

The size of this module can change when CSS is modified in Vector or in core.

Which patch(es) is this happening on?

If it's only https://gerrit.wikimedia.org/r/c/mediawiki/core/+/631177 then this is working correctly.

The error tells you that the change makes Vector's stylesheet larger by 0.1kb

If that's expected Vector needs to be modified to allow for this expansion like in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/641246

In T268593#6645450, @Jdlrobson wrote:

The error tells you that the change makes Vector's stylesheet larger by 0.1kb

But may be the number should not be rounded up/down? I am seeing 8KB > 8KB which is clearly incorrect . Something like 8.1KB > 8KB would surely be understandable by anyone.

Change 643291 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Bump the bundlesize of skins.vector.styles

https://gerrit.wikimedia.org/r/643291

gerritbot added a project: Patch-For-Review.Nov 24 2020, 4:18 PM

We round up to the nearest 0.1kb and 8 is not greater than 8 so this is working fine (I don't think it supports >= but that would be useful if it did). I agree the error message could be a lot clearer TBH.

So should we close this out? As far as I'm concerned https://gerrit.wikimedia.org/r/643291 is an implementation detail of https://phabricator.wikimedia.org/T259903

Yes, thank you

Change 643291 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Bump the bundlesize of skins.vector.styles and skins.vector.styles

https://gerrit.wikimedia.org/r/643291

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 21 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2020, 2:10 PM

Ammarpad mentioned this in T270883: Bundlesize test should be updated to warn rather than fail.Dec 29 2020, 4:54 AM

skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip) Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip)
Closed, ResolvedPublic
Actions