Page MenuHomePhabricator

skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip)
Closed, ResolvedPublic

Description

8KB > 8KB ?

Selenium skins/Vector
Hide Details

04:32:38 > @ selenium-test /workspace/src/skins/Vector
04:32:38 > npm -s run test:size
04:32:38 
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34816 [200]: //load.php?lang=en&modules=skins.vector.styles.legacy
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34818 [200]: //load.php?lang=en&modules=skins.vector.styles
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34820 [200]: //load.php?lang=en&modules=skins.vector.styles.responsive
04:32:40 INFO:backend.DevWebServer:[Tue Nov 24 03:32:40 2020] 127.0.0.1:34822 [200]: //load.php?lang=en&modules=skins.vector.legacy.js
04:32:41  FAIL  skins.vector.styles.legacy: 8KB > maxSize 8KB (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.styles.responsive: 553B < maxSize 614B (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.legacy.js: 1.76KB < maxSize 1.8KB (gzip) 
04:32:41 
04:32:41  PASS  skins.vector.styles: 9.05KB < maxSize 9.1KB (gzip)

https://integration.wikimedia.org/ci/job/mediawiki-quibble-selenium-vendor-mysql-php72-docker/5169/console

Event Timeline

This looks strange and is repeatedly happening so it's not one-off

The size of this module can change when CSS is modified in Vector or in core.

Which patch(es) is this happening on?

If it's only https://gerrit.wikimedia.org/r/c/mediawiki/core/+/631177 then this is working correctly.

The error tells you that the change makes Vector's stylesheet larger by 0.1kb

If that's expected Vector needs to be modified to allow for this expansion like in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/641246

The error tells you that the change makes Vector's stylesheet larger by 0.1kb

But may be the number should not be rounded up/down? I am seeing 8KB > 8KB which is clearly incorrect . Something like 8.1KB > 8KB would surely be understandable by anyone.

Change 643291 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Bump the bundlesize of skins.vector.styles

https://gerrit.wikimedia.org/r/643291

We round up to the nearest 0.1kb and 8 is not greater than 8 so this is working fine (I don't think it supports >= but that would be useful if it did). I agree the error message could be a lot clearer TBH.

So should we close this out? As far as I'm concerned https://gerrit.wikimedia.org/r/643291 is an implementation detail of https://phabricator.wikimedia.org/T259903

Ammarpad claimed this task.

Yes, thank you

Change 643291 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Bump the bundlesize of skins.vector.styles and skins.vector.styles

https://gerrit.wikimedia.org/r/643291