Page MenuHomePhabricator

PushToWatch extension does not show anything in page footer
Closed, ResolvedPublic

Description

I've installed the PushToWatch extension on my "testing wiki", so I can test @thiemowmde's patch. And I've found that extension no works. I've merged his patch, as behavior is same, but code looks much better.

Extension is correctly loaded and appears in the Special:Version:

Per documentation on MediaWiki.org, option should be in footer, but there isn't any option.

If someone know how-to fix this problem, it would be great. If not, we maybe should think about the option of archiving.


Version details:

ProductVersion
MediaWiki1.36.0-alpha (20f5062)
PHP7.4.12 (litespeed)
MariaDB10.3.27-MariaDB
ICU63.1

Event Timeline

Aklapper renamed this task from PushToWatch extension is broken to PushToWatch extension does not show anything in page footer.Nov 24 2020, 2:20 PM

Change 643270 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/PushToWatch@master] Have the form show up again in the page footer on MW 1.35+

https://gerrit.wikimedia.org/r/643270

@ashley Thank you for creating of patch.
Screenshot for my comment:

@ashley Thank you for creating of patch.

Did you:

  1. purge the page after pulling the patch from gerrit?
  2. try a non-Vector skin? (Vector seems to be very...special these days; for example, NewsBox on 1.35+ just simply doesn't work on Vector and I had to explicitly disable it for Vector)

Mind you, it seems to be working even with Vector on my local 1.35 install; I see an input, much like in the MW.org page screenshot image, in the footer.

  1. purge the page after pulling the patch from gerrit?

Sure, I do it always.

  1. try a non-Vector skin?

With Minerva no works too.

Mind you, it seems to be working even with Vector on my local 1.35 install

I'm using 1.36 (master branch).

I found those things in the logs:

dberror.log
Tue Nov 24 16:20:46 CET 2020    fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw       Error 1054 from PushToWatch::getUsers, Unknown column 'user.user_id' in 'on clause' (localhost) SELECT  DISTINCT user_name  FROM `mwuser` JOIN `mwwatchlist` ON ((user.user_id = watchlist.wl_user))   WHERE wl_title = 'Test_page'   localhost
#0 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string,string, boolean)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query(string, string, integer)
#3 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, string, array, string, array, array)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(63): Wikimedia\Rdbms\DBConnRef->select(array, string, array, string, array, array)
#6 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(119): PushToWatch::getUsers(Title)
#7 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): PushToWatch::onSkinAddFooterLinks(SkinVector, string, array)
#8 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#9 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3465): MediaWiki\HookContainer\HookContainer->run(string, array)
#10 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/Skin.php(2571): MediaWiki\HookContainer\HookRunner->onSkinAddFooterLinks(SkinVector, string, array)
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(249): Skin->getFooterLinks()
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(187): SkinMustache->getFooterTemplateData()
#13 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(120): SkinMustache->getTemplateData()
#14 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#15 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#16 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#17 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#18 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#19 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#20 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#21 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#22 {main}
Tue Nov 24 16:20:46 CET 2020    fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw       Error 1054 from PushToWatch::getUsers, Unknown column 'user.user_id' in 'on clause' (localhost) SELECT  DISTINCT user_name  FROM `mwuser` JOIN `mwwatchlist` ON ((user.user_id = watchlist.wl_user))   WHERE wl_title = 'Test_page'   localhost
#0 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string,string, boolean)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query(string, string, integer)
#3 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, string, array, string, array, array)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(63): Wikimedia\Rdbms\DBConnRef->select(array, string, array, string, array, array)
#6 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(119): PushToWatch::getUsers(Title)
#7 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): PushToWatch::onSkinAddFooterLinks(SkinVector, string, array)
#8 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#9 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3465): MediaWiki\HookContainer\HookContainer->run(string, array)
#10 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/Skin.php(2571): MediaWiki\HookContainer\HookRunner->onSkinAddFooterLinks(SkinVector, string, array)
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(249): Skin->getFooterLinks()
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(187): SkinMustache->getFooterTemplateData()
#13 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(120): SkinMustache->getTemplateData()
#14 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#15 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#16 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#17 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#18 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#19 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#20 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#21 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#22 {main}
error.log
2020-11-24 15:20:46 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw: [f2f00f8911953460fa001876] /index.php/Test_page?uselang=en   ErrorException from line 95 of /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php: PHP Notice: Undefined variable: output
#0 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(95): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(119): PushToWatch::getUsers(Title)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): PushToWatch::onSkinAddFooterLinks(SkinVector, string, array)
#3 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3465): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/Skin.php(2571): MediaWiki\HookContainer\HookRunner->onSkinAddFooterLinks(SkinVector, string, array)
#6 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(249): Skin->getFooterLinks()
#7 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(187): SkinMustache->getFooterTemplateData()
#8 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(120): SkinMustache->getTemplateData()
#9 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#10 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#13 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#14 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#15 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#16 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#17 {main}
2020-11-24 15:20:46 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw: [f2f00f8911953460fa001876] /index.php/Test_page?uselang=en   ErrorException from line 329 of /home/kizuletk/public_html/wiki.kizule.ga/includes/debug/MWDebug.php: PHP Deprecated: Caller from PushToWatch::getUsers ignored an error originally raised from PushToWatch::getUsers: [1054] Unknown column 'user.user_id' in 'on clause' (localhost)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /home/kizuletk/public_html/wiki.kizule.ga/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/db/MWLBFactory.php(341): MWDebug::sendRawDeprecated(string, boolean, string)
#3 [internal function]: MWLBFactory::logDeprecation(string)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1511): call_user_func(array, string)
#5 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1220): Wikimedia\Rdbms\Database->assertQueryIsCurrentlyAllowed(string, string)
#6 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query(string, string, integer)
#7 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, string, array, string, array, array)
#8 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#9 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(63): Wikimedia\Rdbms\DBConnRef->select(array, string, array, string, array, array)
#10 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(119): PushToWatch::getUsers(Title)
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): PushToWatch::onSkinAddFooterLinks(SkinVector, string, array)
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array,array, array)
#13 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3465): MediaWiki\HookContainer\HookContainer->run(string, array)
#14 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/Skin.php(2571): MediaWiki\HookContainer\HookRunner->onSkinAddFooterLinks(SkinVector, string, array)
#15 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(249): Skin->getFooterLinks()
#16 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(187): SkinMustache->getFooterTemplateData()
#17 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(120): SkinMustache->getTemplateData()
#18 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#19 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#20 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#21 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#22 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#23 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#24 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#25 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#26 {main}
2020-11-24 15:20:46 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw: [f2f00f8911953460fa001876] /index.php/Test_page?uselang=en   ErrorException from line 95 of /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php: PHP Notice: Undefined variable: output
#0 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(95): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /home/kizuletk/public_html/wiki.kizule.ga/extensions/PushToWatch/src/PushToWatch.php(119): PushToWatch::getUsers(Title)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): PushToWatch::onSkinAddFooterLinks(SkinVector, string, array)
#3 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3465): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/Skin.php(2571): MediaWiki\HookContainer\HookRunner->onSkinAddFooterLinks(SkinVector, string, array)
#6 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(249): Skin->getFooterLinks()
#7 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(187): SkinMustache->getFooterTemplateData()
#8 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(120): SkinMustache->getTemplateData()
#9 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#10 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#13 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#14 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#15 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#16 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#17 {main}
2020-11-24 15:20:46 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw: [f2f00f8911953460fa001876] /index.php/Test_page?uselang=en   ErrorException from line 329 of /home/kizuletk/public_html/wiki.kizule.ga/includes/debug/MWDebug.php: PHP Deprecated: Caller from EchoEventMapper::fetchUnreadByUserAndPage ignored an error originallyraised from PushToWatch::getUsers: [1054] Unknown column 'user.user_id' in 'on clause' (localhost)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /home/kizuletk/public_html/wiki.kizule.ga/includes/debug/MWDebug.php(329): trigger_error(string, integer)
#2 /home/kizuletk/public_html/wiki.kizule.ga/includes/db/MWLBFactory.php(341): MWDebug::sendRawDeprecated(string, boolean, string)
#3 [internal function]: MWLBFactory::logDeprecation(string)
#4 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1511): call_user_func(array, string)
#5 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1220): Wikimedia\Rdbms\Database->assertQueryIsCurrentlyAllowed(string, string)
#6 /home/kizuletk/public_html/wiki.kizule.ga/includes/libs/rdbms/database/Database.php(1907): Wikimedia\Rdbms\Database->query(string, string, integer)
#7 /home/kizuletk/public_html/wiki.kizule.ga/extensions/Echo/includes/mapper/EventMapper.php(172): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#8 /home/kizuletk/public_html/wiki.kizule.ga/extensions/Echo/includes/EchoHooks.php(880): EchoEventMapper->fetchUnreadByUserAndPage(User, integer)
#9 /home/kizuletk/public_html/wiki.kizule.ga/extensions/Echo/includes/EchoHooks.php(1024): EchoHooks::processMarkAsRead(User, WebRequest, Title)
#10 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(333): EchoHooks::onPersonalUrls(array, Title, SkinVector)
#11 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookContainer.php(140): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array,array, array)
#12 /home/kizuletk/public_html/wiki.kizule.ga/includes/HookContainer/HookRunner.php(3059): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#13 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(634): MediaWiki\HookContainer\HookRunner->onPersonalUrls(array, Title, SkinVector)
#14 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(312): SkinTemplate->buildPersonalUrls()
#15 /home/kizuletk/public_html/wiki.kizule.ga/skins/Vector/includes/SkinVector.php(138): SkinVector->getMenuProps()
#16 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinMustache.php(128): SkinVector->getTemplateData()
#17 /home/kizuletk/public_html/wiki.kizule.ga/includes/skins/SkinTemplate.php(138): SkinMustache->generateHTML()
#18 /home/kizuletk/public_html/wiki.kizule.ga/includes/OutputPage.php(2626): SkinTemplate->outputPage()
#19 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(950): OutputPage->output(boolean)
#20 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(963): MediaWiki->{closure}()
#21 /home/kizuletk/public_html/wiki.kizule.ga/includes/MediaWiki.php(546): MediaWiki->main()
#22 /home/kizuletk/public_html/wiki.kizule.ga/index.php(53): MediaWiki->run()
#23 /home/kizuletk/public_html/wiki.kizule.ga/index.php(46): wfIndexMain()
#24 {main}

I found those things in the logs:
Tue Nov 24 16:20:46 CET 2020 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw Error 1054 from PushToWatch::getUsers, Unknown column 'user.user_id' in 'on clause' (localhost) SELECT DISTINCT user_name FROM mwuser JOIN mwwatchlist ON ((user.user_id = watchlist.wl_user)) WHERE wl_title = 'Test_page' localhost

This was caused by the fact that your $wgDBprefix is set to mw but the extension failed to take $wgDBprefix into account. https://gerrit.wikimedia.org/r/643281/ should fix that.

Yep, extension works now.

I've "pushed to watch" account Admin, and it works. But, confirmation message should be added on wiki, like we have for successful editing of the page.

I got an email now. Extension should send message as wiki: Name of wiki <mail of wiki>, not my account (My username <my email>).

Change 643285 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/PushToWatch@master] Fix runtime issues

https://gerrit.wikimedia.org/r/643285

Maybe we should also have a log on Special:Log for this.

@ashley Maybe space should be added after Push to watch: and before input box.

Change 643270 merged by jenkins-bot:
[mediawiki/extensions/PushToWatch@master] Have the form show up again in the page footer on MW 1.35+

https://gerrit.wikimedia.org/r/643270

Change 643285 merged by jenkins-bot:
[mediawiki/extensions/PushToWatch@master] Fix runtime issues

https://gerrit.wikimedia.org/r/643285

Thank you very much @ashley and @thiemowmde for patches which made this extension works again. I will create follow-up tasks for things which still needs to be fixed.