Page MenuHomePhabricator

Add "footer"
Open, LowPublic3 Estimated Story Points

Description

Spinning off from T265240#6630783. We need a section to put link to source code, privacy policy, report a bug, etc. It's usually footer but we probably need to put it somewhere else.

mocks
desktop

mobile

LINKS

AC

  • footer body should never surpass the outer edges of the iframe (visualised with green dotted lines in mock)
  • when body no longer fits next to each other, the second section should move below the first
  • the margin between the two columns in the horizontal layout is removed in the vertical layout

OPEN QUESTION

  • max and min width of each column. is there an invisible third column?
    • currently no max-width on columns

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is done? @Michael

No. This still needs actual official design and copy by @Charlie_WMDE.

On the technical side, this needs translatable messages instead of hard-coded strings, but that only makes sense after we have the official copy.

Lydia_Pintscher moved this task from Incoming to Backlog on the Wikidata Query Builder board.
Charlie_WMDE updated the task description. (Show Details)
Charlie_WMDE moved this task from Backlog to Ready for story time on the Wikidata Query Builder board.
Lydia_Pintscher set the point value for this task to 3.
Ladsgroup updated the task description. (Show Details)
Ladsgroup moved this task from Ready to pick up to Doing on the Wikidata Query Builder board.

Change 676126 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[wikidata/query-builder@master] Footer as envisioned by the UX

https://gerrit.wikimedia.org/r/676126

Change 676126 merged by jenkins-bot:

[wikidata/query-builder@master] Footer as envisioned by the UX

https://gerrit.wikimedia.org/r/676126

looks good. i'm just not sure why the column headers are displayed in such a large font (at least in firefox)

oh thanks. I went with <p> first but it was brought up that it's better to use <h2> and now it's using h2's CSS. Let me fix that.

Change 677342 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[wikidata/query-builder@master] Footer: Repeat the font-size css for h2 to override browser's default

https://gerrit.wikimedia.org/r/677342

Change 677342 merged by jenkins-bot:

[wikidata/query-builder@master] Footer: Repeat the font-size css for h2 to override browser's default

https://gerrit.wikimedia.org/r/677342