Rollbacks improperly reported under race condition
Closed, ResolvedPublic


Author: Winbots

Fixes bug.

Rollbacks can be improperly reported under certain race conditions. Mainly because the doEdit call's status is never checked before notifying of a successful rollback.

The diff should fix this.


Version: 1.17.x
Severity: enhancement

Attached: racecondition.diff

bzimport added a project: MediaWiki-Page-editing.Via ConduitNov 21 2014, 11:02 PM
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz24866.
bzimport created this task.Via LegacyAug 19 2010, 5:23 AM
liangent added a comment.Via ConduitAug 19 2010, 5:32 AM

Using the message "Cannot revert edit; last contributor is only author of this page." is bad. A new message should be added.

Reedy added a comment.Via ConduitAug 19 2010, 9:27 AM

You should really have it with braces as per the coding style guidelines

if( !$status->isOK() ) {
return array( array( 'cantrollback' ) );

bzimport added a comment.Via ConduitMay 14 2011, 2:20 PM

Bryan.TongMinh wrote:

Marking as reviewed per comment #2.

duplicatebug added a comment.Via ConduitMar 8 2014, 8:13 AM

Check for $status->isOk was added with gerrit 21662

Add Comment