PR: https://github.com/wmde/fundraising-banners/pull/480

@AbbanWMDE Quite a bunch of comments this time:

• First of all, the start can (and probably should) be postponed to tomorrow.
• It seems, that the control banner's progress bar has large top and bottom margins, which is probably a leftover of some 2019 same height banner test. This can be reduced and would thus reduce the whitespace in the variant banner.
• During design phase, the UX team was pretty specific about putting the progress bar inside the slides and have the slide indicators at the very bottom. Can we maybe hack it using z-index to prevent five instantiations of the progress bar?
• Related to that, the slide switching arrows are not centered vertically.
• The content is not centered horizontally and has a larger spacing to the left than to the right.
• The donation target should be displayed outside of the progress bar to prevent it from overlapping the filled area. It's probably best to use the mobile one that displays labels above the bar.
• Due to the large whitespace, the campaigns team reordered the copy. I updated the slide content in the task description accordingly.
• And two things that might just not be feasible easily:
  • In the design, the active slide is indicated by a circle instead of a dics. If that is something the used library doesn't support, it's not a big deal, though.
  • The info icon should not push the first line right, but stay left of it, so that all lines align well.

Thanks, @AbbanWMDE! Almost there:

• The banners are different in height (probably because the progress bar is missing from the control banner content in var).
• The donation target label makes the progress bar look too small in the portrait mode of 1024x768 devices. Can you change it to display the donation target label above the progress bar (like in the mobile banners)?
• The auto-sliding happens way too fast/soon. Can you change the autosliding interval to 10 seconds?

@kai.nissen Those fixes are in and uploaded now.

@AbbanWMDE I had to switch back to the previous test, because the form of the variant banner was not submittable. The console doesn't log an error on clicking the button, but does so at first interaction with any of the form buttons:

Uncaught (in promise) TypeError: this.adjustSurroundingSpace is not a function

The test would need to be restarted with new tracking parameters once this is fixed.