Normally rebuildLocalisationCache.php clears the MessageBlobStore global cache after it rebuilds the CDB file for a given language. Sometimes this call happens at an inappropriate time, such as before new CDB files have been prepared on target servers. We need a way to control whether or not rebuildLocalisationCache clears the global cache.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T198901 Migrate production services to kubernetes using the pipeline | |||
| Open | None | T238770 Deploy MediaWiki to Wikimedia production in containers | |||
| Resolved | dancy | T260827 l10n process for MW containerization | |||
| Resolved | dancy | T268698 Add flag to rebuildLocalisationCache.php to skip MessageBlobStore::clearGlobalCacheEntry |
Event Timeline
Comment Actions
Change 643370 had a related patch set uploaded (by Ahmon Dancy; owner: Ahmon Dancy):
[mediawiki/core@master] Add flag to rebuildLocalisationCache.php to skip MessageBlobStore clear
Comment Actions
@dancy: Assuming this task is about the maintenance scripts in MediaWiki core, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!
Comment Actions
Change 643370 merged by jenkins-bot:
[mediawiki/core@master] Add flag to rebuildLocalisationCache.php to skip MessageBlobStore clear
Comment Actions
Moving to LocalisationCache component since it's not a issue with the Maintenance script system in general.
Comment Actions
@Krinkle
Regarding your question in mediawiki IRC: at the end of scap sync-world or scap sync-l10n, scap calls tasks.clear_message_blobs() which runs mwscript extensions/WikimediaMaintenance/refreshMessageBlobs.php
Also, my concern with the unnecessary MBS clearing is that it (presumably) increases the load on the appservers due to the subsequent cache misses. I don't know what the magnitude of that impact is though.
Comment Actions
For the record https://gerrit.wikimedia.org/r/c/mediawiki/core/+/667735 replaced --no-clear-message-blob-store with --offline.
Comment Actions
Change 677375 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] rebuildLocalisationCache: Add --skip-message-purge and accompanying script
Comment Actions
Change 677616 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):
[mediawiki/tools/scap@master] Use --skip-message-purge instead of --offline
Comment Actions
Change 677375 merged by jenkins-bot:
[mediawiki/core@master] rebuildLocalisationCache: Add --skip-message-purge and accompanying script
Comment Actions
Change 678987 had a related patch set uploaded (by Legoktm; author: Krinkle):
[mediawiki/core@REL1_36] rebuildLocalisationCache: Add --skip-message-purge and accompanying script
Comment Actions
Change 678987 merged by jenkins-bot:
[mediawiki/core@REL1_36] rebuildLocalisationCache: Add --skip-message-purge and accompanying script
Comment Actions
Change 677616 merged by jenkins-bot:
[mediawiki/tools/scap@master] Use --skip-message-purge instead of --offline