Add a link: difficulty overlay and difficulty filter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MMiller_WMF
	Nov 25 2020, 1:40 AM

Description

The new task replaces the old "add links" task in the difficulty overlay (which the user experiences when initiating the suggested edits module in Variant D) and the difficulty filter in the module itself. The specifications are the same for both mobile and desktop.

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.
Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks (will be fixed in T278123: Provide capability for A/B testing task types)
Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes
Use the same CSS class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same
Title: "Add links between articles"
We are introducing a subtitle for this task type, which will read: "Suggestions by artificial intelligence (AI)"
The subtitle should be preceded by a robot icon.

Mockup of mobile difficulty overlay as of 2021-01-12:

Mockup of desktop difficulty overlay in Variant D as of 2021-01-12:

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
Mobile: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65
Desktop: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=112%3A0

Details

Subject	Repo	Branch	Lines +/-
StartEditing: Update message	mediawiki/extensions/GrowthExperiments	master	+1 -1
Fix styling for additional message and checkbox on task type selection	mediawiki/extensions/GrowthExperiments	master	+35 -21
Apply icon styles only to task type icon, not checkbox	mediawiki/extensions/GrowthExperiments	master	+6 -6
Add robot icon and AI description to difficultyFilter checkbox	mediawiki/extensions/GrowthExperiments	master	+42 -2
Use iconData array to display tasktype icons	mediawiki/extensions/GrowthExperiments	master	+28 -20

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	MMiller_WMF	T252822 [EPIC] Growth: "add a link" structured task 1.0
Resolved	kostajh	T268704 Add a link: frontend product specifications
Resolved	kostajh	T268706 Add a link: difficulty overlay and difficulty filter

Event Timeline

MMiller_WMF created this task.Nov 25 2020, 1:40 AM

MMiller_WMF updated the task description. (Show Details)

MMiller_WMF updated the task description. (Show Details)Dec 8 2020, 3:41 PM

MMiller_WMF updated the task description. (Show Details)Jan 13 2021, 1:17 AM

RHo updated the task description. (Show Details)Jan 13 2021, 10:53 AM

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 18 2021, 4:26 PM

I can take a look at this one since I was just working in the StartEditingDialog and DifficultyFilters.

@mepps -- thanks! Once you begin work, please move this task to the "In Progress" column.

• mepps mentioned this in T268707: Add a link: task type info in suggested edits module.Feb 16 2021, 5:38 PM

MMiller_WMF updated the task description. (Show Details)Feb 19 2021, 3:51 AM

MMiller_WMF mentioned this in T268704: Add a link: frontend product specifications.Feb 19 2021, 4:18 AM

Change 667016 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] WIP Use Boolean isAISuggestion to decide whether to display icon data

https://gerrit.wikimedia.org/r/667016

gerritbot added a project: Patch-For-Review.Feb 25 2021, 8:59 PM

kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 26 2021, 8:44 AM

Change 668540 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] WIP Add icon and description to TaskTypeFilter checkbox for DifficultyFilter

https://gerrit.wikimedia.org/r/668540

Change 668541 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] Add robot icon and AI description to difficultyFilter checkbox

https://gerrit.wikimedia.org/r/668541

• mewoph moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 12 2021, 7:07 PM

• mewoph mentioned this in T268705: Add a link: mobile module preview.Mar 12 2021, 7:22 PM

Change 667016 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Use iconData array to display tasktype icons

https://gerrit.wikimedia.org/r/667016

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 12 2021, 8:00 PM

MBinder_WMF unsubscribed.Mar 12 2021, 8:24 PM

@mepps - Moving to Needs more work since Add robot icon and AI description to difficultyFilter checkbox patch needs some minor fixes.

kostajh moved this task from Backlog to In progress on the Add-Link board.Mar 22 2021, 10:51 AM

kostajh moved this task from Test in Production | Watching to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 25 2021, 8:15 PM

kostajh moved this task from In progress to Done / QA on the Add-Link board.

Change 668541 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add robot icon and AI description to difficultyFilter checkbox

https://gerrit.wikimedia.org/r/668541

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 25 2021, 9:00 PM

Etonkovidova updated the task description. (Show Details)Mar 26 2021, 2:03 AM

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockup	betalabs

(2)

Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Apart from the items from the above comment, I'm moving the task for @RHo review with the following quesitons
(1) Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes.

Screen Shot 2021-03-25 at 6.17.59 PM.png (253×633 px, 47 KB)

Screen Shot 2021-03-25 at 6.17.31 PM.png (425×639 px, 62 KB)

(2) I saw in Figma the different specs for Caption-Hatnote. The color is fine, but the font-size and line-height seem to be different from Figma. However, the way it's implemented seem fine to me.

Figma	betalabs

In T268706#6947682, @Etonkovidova wrote:

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockup betalabs

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

(2)

Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Pretty sure this is dependent on the order that tasks are defined in MediaWiki:NewcomerTasks.json. In any case, in T277356: Add a link: experiment we'll be setting up users with link-recommendation as their only enabled task type, so I would propose we not worry about this detail right now.

In T268706#6948254, @kostajh wrote:

In T268706#6947682, @Etonkovidova wrote:

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockup betalabs

hi @Etonkovidova - we decided that the copy should follow the copy doc and task description, so that's the reason why it is still on the mocks.

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

hi @kostajh - I do think it is important to remove it, so can we not just update the existing message and remove that second sentence as an update, similar to T275182 but also updating the copy as well as the QQQs?

(2)

Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Pretty sure this is dependent on the order that tasks are defined in MediaWiki:NewcomerTasks.json. In any case, in T277356: Add a link: experiment we'll be setting up users with link-recommendation as their only enabled task type, so I would propose we not worry about this detail right now.

Fair enough

In T268706#6947696, @Etonkovidova wrote:

Apart from the items from the above comment, I'm moving the task for @RHo review with the following quesitons
(1) Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes.

Thanks @Etonkovidova - you're right, the checkbox should the the same as the others. At the moment it is a paler shade of blue as though there is an opacity on it? Moving back to fix this item please @mepps.

(2) I saw in Figma the different specs for Caption-Hatnote. The color is fine, but the font-size and line-height seem to be different from Figma. However, the way it's implemented seem fine to me.

Figma betalabs

Agree that this is quite close, though I would recommend if the above item needs review anyway that it might be better to use the same class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same:

CS Beta

Figma

In T268706#6948705, @RHo wrote:

In T268706#6948254, @kostajh wrote:

In T268706#6947682, @Etonkovidova wrote:

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockup betalabs

hi @Etonkovidova - we decided that the copy should follow the copy doc and task description, so that's the reason why it is still on the mocks.

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

hi @kostajh - I do think it is important to remove it, so can we not just update the existing message and remove that second sentence as an update, similar to T275182 but also updating the copy as well as the QQQs?

Yes, we can do that. All translation will still need to be updated but if we don't have any use for the existing two sentence message, then we need to do this. @mepps could you please do this as part of the other fixes needed for this task?

kostajh removed • mepps as the assignee of this task.Apr 13 2021, 2:51 PM

kostajh moved this task from Done / QA to April 12 - April 16 on the Add-Link board.

kostajh moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh triaged this task as Medium priority.Apr 14 2021, 12:53 PM

kostajh claimed this task.Apr 15 2021, 8:31 AM

kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 679708 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] StartEditing: Update message

https://gerrit.wikimedia.org/r/679708

kostajh updated the task description. (Show Details)Apr 15 2021, 8:37 AM

kostajh updated the task description. (Show Details)

Change 679745 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Apply consistent styles for additional message on task type selection

https://gerrit.wikimedia.org/r/679745

Change 679746 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Apply icon styles only to task type icon, not checkbox

https://gerrit.wikimedia.org/r/679746

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 15 2021, 10:27 AM

Change 679746 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] Apply icon styles only to task type icon, not checkbox

Reason:

squashed

https://gerrit.wikimedia.org/r/679746

• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 15 2021, 4:17 PM

• mewoph moved this task from April 12 - April 16 to Done / QA on the Add-Link board.Apr 15 2021, 4:40 PM

Change 679708 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] StartEditing: Update message

https://gerrit.wikimedia.org/r/679708

Change 679745 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix styling for additional message and checkbox on task type selection

https://gerrit.wikimedia.org/r/679745

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 5:00 PM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:48 PM

Etonkovidova updated the task description. (Show Details)Apr 20 2021, 12:35 AM

For Design review - I removed all red exclamation marks since all has been corrected.

To summarize
(1) DONE

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

Screen Shot 2021-04-19 at 5.34.34 PM.png (657×663 px, 89 KB)

(2) Will be done in T278123

Like the task it replaces, it should still be the first task in the list of task types [...]

(3) DONE

Use the same CSS class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same

The specs are in place and the CSS is the same as for the subheader for "Create a new article":

Screen Shot 2021-04-19 at 5.42.40 PM.png (706×656 px, 102 KB)

LGTM, thanks all!

MMiller_WMF mentioned this in T289826: Add an image: difficulty filter.Aug 27 2021, 12:19 AM

MMiller_WMF mentioned this in T294669: Image instrumentation: image inspector.Oct 29 2021, 10:23 PM

Urbanecm_WMF removed a project: Growth-Team-Filtering.Feb 5 2022, 4:51 PM

	F34408119: Screen Shot 2021-04-19 at 5.34.34 PM.png
	Apr 20 2021, 12:47 AM

	F34408123: Screen Shot 2021-04-19 at 5.42.40 PM.png
	Apr 20 2021, 12:47 AM

	F34191272: Screen Shot 2021-03-25 at 6.11.16 PM.png
	Mar 26 2021, 2:46 AM

	F34191264: Screen Shot 2021-03-25 at 6.17.59 PM.png
	Mar 26 2021, 2:46 AM

	F34191268: Screen Shot 2021-03-25 at 6.11.54 PM.png
	Mar 26 2021, 2:46 AM

	F34191266: Screen Shot 2021-03-25 at 6.17.31 PM.png
	Mar 26 2021, 2:46 AM

	F34191801: image.png
	Mar 26 2021, 1:00 PM

	F34191810: image.png
	Mar 26 2021, 1:00 PM

Add a link: difficulty overlay and difficulty filterClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Add a link: difficulty overlay and difficulty filter
Closed, ResolvedPublic
Actions

Related Objects
Search...