Page MenuHomePhabricator

Add a link: difficulty overlay and difficulty filter
Closed, ResolvedPublic

Description

The new task replaces the old "add links" task in the difficulty overlay (which the user experiences when initiating the suggested edits module in Variant D) and the difficulty filter in the module itself. The specifications are the same for both mobile and desktop.

  • With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.
  • Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks (will be fixed in T278123: Provide capability for A/B testing task types)
  • Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes
  • Use the same CSS class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same
  • Title: "Add links between articles"
  • We are introducing a subtitle for this task type, which will read: "Suggestions by artificial intelligence (AI)"
  • The subtitle should be preceded by a robot icon.
Mockup of mobile difficulty overlay as of 2021-01-12:
Mockup of desktop difficulty overlay in Variant D as of 2021-01-12:

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
Mobile: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65
Desktop: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=112%3A0

Event Timeline

mepps added a subscriber: mepps.

I can take a look at this one since I was just working in the StartEditingDialog and DifficultyFilters.

@mepps -- thanks! Once you begin work, please move this task to the "In Progress" column.

Change 667016 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] WIP Use Boolean isAISuggestion to decide whether to display icon data

https://gerrit.wikimedia.org/r/667016

Change 668540 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] WIP Add icon and description to TaskTypeFilter checkbox for DifficultyFilter

https://gerrit.wikimedia.org/r/668540

Change 668541 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] Add robot icon and AI description to difficultyFilter checkbox

https://gerrit.wikimedia.org/r/668541

Change 667016 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Use iconData array to display tasktype icons

https://gerrit.wikimedia.org/r/667016

Change 668541 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add robot icon and AI description to difficultyFilter checkbox

https://gerrit.wikimedia.org/r/668541

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

  • With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockupbetalabs

(2)

  • Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Apart from the items from the above comment, I'm moving the task for @RHo review with the following quesitons
(1) Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes.

(2) I saw in Figma the different specs for Caption-Hatnote. The color is fine, but the font-size and line-height seem to be different from Figma. However, the way it's implemented seem fine to me.

Figmabetalabs

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

  • With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockupbetalabs

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

(2)

  • Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Pretty sure this is dependent on the order that tasks are defined in MediaWiki:NewcomerTasks.json. In any case, in T277356: Add a link: experiment we'll be setting up users with link-recommendation as their only enabled task type, so I would propose we not worry about this detail right now.

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

  • With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockupbetalabs

hi @Etonkovidova - we decided that the copy should follow the copy doc and task description, so that's the reason why it is still on the mocks.

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

hi @kostajh - I do think it is important to remove it, so can we not just update the existing message and remove that second sentence as an update, similar to T275182 but also updating the copy as well as the QQQs?

(2)

  • Like the task it replaces, it should still be the first task in the list of task types, with the "easy" tasks.

Technically speaking, the first task was always Copyright. According to the specs it should be replaced with "Add links to other Wikipedia articles" and presently it's not done.

Pretty sure this is dependent on the order that tasks are defined in MediaWiki:NewcomerTasks.json. In any case, in T277356: Add a link: experiment we'll be setting up users with link-recommendation as their only enabled task type, so I would propose we not worry about this detail right now.

Fair enough

Apart from the items from the above comment, I'm moving the task for @RHo review with the following quesitons
(1) Currently the AI option check box gets a paler color (and a paler border). I did not see it in Figma mockups ( but it could be that I missed it) and it differs from other checkboxes.

Thanks @Etonkovidova - you're right, the checkbox should the the same as the others. At the moment it is a paler shade of blue as though there is an opacity on it? Moving back to fix this item please @mepps.

(2) I saw in Figma the different specs for Caption-Hatnote. The color is fine, but the font-size and line-height seem to be different from Figma. However, the way it's implemented seem fine to me.

Figmabetalabs

Agree that this is quite close, though I would recommend if the above item needs review anyway that it might be better to use the same class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same:

CS Beta
Figma

@mepps Unless I missed some updates on the specs (and Figma mockups), but there are still two items from the task description that need to be done.

(1)

  • With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

The Figma mockups still have the line and so the current introduction tour text.

figma mockupbetalabs

hi @Etonkovidova - we decided that the copy should follow the copy doc and task description, so that's the reason why it is still on the mocks.

@RHo @MMiller_WMF Can we just leave this sentence as it is please? To remove it, we would have to take an existing message and split it into two, which is more work for translators.

hi @kostajh - I do think it is important to remove it, so can we not just update the existing message and remove that second sentence as an update, similar to T275182 but also updating the copy as well as the QQQs?

Yes, we can do that. All translation will still need to be updated but if we don't have any use for the existing two sentence message, then we need to do this. @mepps could you please do this as part of the other fixes needed for this task?

kostajh moved this task from Done / QA to April 12 - April 16 on the Add-Link board.
kostajh triaged this task as Medium priority.Apr 14 2021, 12:53 PM

Change 679708 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] StartEditing: Update message

https://gerrit.wikimedia.org/r/679708

kostajh updated the task description. (Show Details)

Change 679745 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Apply consistent styles for additional message on task type selection

https://gerrit.wikimedia.org/r/679745

Change 679746 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Apply icon styles only to task type icon, not checkbox

https://gerrit.wikimedia.org/r/679746

Change 679746 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] Apply icon styles only to task type icon, not checkbox

Reason:

squashed

https://gerrit.wikimedia.org/r/679746

Change 679708 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] StartEditing: Update message

https://gerrit.wikimedia.org/r/679708

Change 679745 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix styling for additional message and checkbox on task type selection

https://gerrit.wikimedia.org/r/679745

For Design review - I removed all red exclamation marks since all has been corrected.

To summarize
(1) DONE

With the introduction of AI suggestions, we want to remove the line in the first paragraph of the dialog that currently reads, "The community of editors has listed articles that need different kinds of help." That sentence should just be removed, and replaced with nothing.

(2) Will be done in T278123

Like the task it replaces, it should still be the first task in the list of task types [...]

(3) DONE

Use the same CSS class for the supplementary text styling under both this new AI task, and the existing supplementary text in "Create new article" so that both are the same

The specs are in place and the CSS is the same as for the subheader for "Create a new article":

LGTM, thanks all!