Page MenuHomePhabricator

Add a link: task type info in suggested edits module
Closed, ResolvedPublic

Description

For this task type in the suggested edits module, here are the details on how it should be listed. Several of these specifications are not changed from what is used for the old "add links" task type. These specifications are the same on desktop and mobile.

  • Title: "Add links between articles"
  • Subtitle: "Make words from one article link to another article."
  • Difficulty level is EASY
  • Robot icon precedes the word EASY
  • Estimated time is "3-5 minutes"
  • Tooltip from the "i" icon: "Adding links is the easiest way to edit. Links allow readers to click on something they want to learn more about. [paragraph break] The AI will suggest links, and you will decide whether to add them to the article."
Mockup of mobile and tooltip as of 2021-01-12:
image.png (608×718 px, 256 KB)
Mockup of desktop and hover states as of 2021-01-12:
image.png (555×718 px, 179 KB)

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
Mobile: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65
Desktop: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=112%3A0

Event Timeline

Change 647126 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Add messages for link-recommendation task type

https://gerrit.wikimedia.org/r/647126

This patch adds the messages, but it doesn't add the robot icon. I'm also not sure if paragraph breaks are currently supported in those tooltips, I'll have to check.

Change 647126 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add messages for link-recommendation task type

https://gerrit.wikimedia.org/r/647126

@kostajh suggested working on this before T268706.

@mepps -- I'm glad you'll be working on this task! Once you get started, please move it to the In Progress column.

@RHo @MMiller_WMF Are we planning to use this robot icon with add an image too? It just might change my approach.

Hi @mepps - I think very likely we would use the same robot icon to indicate AI structured tasks, yes. Also, in case it is not clear from inspecting the Figma, the robot icon is from the OOUI icon library

Thanks @RHo!

I looked at this today. @kostajh and I discussed adding an "icon" property to the taskType object, specified in NewcomerTasks.json. I was trying to figure out where taskTypes in the TaskExplanationWidget gets the TaskTypes.json from. It looks like it's generated in TaskType.php so I'll be working there tomorrow.

@RHo @mepps I'm looking at a similar task. If I understand correctly, the OOUI icon library specifies the color of the icon as well and that only has blue/progressive and black. Would we need a new SVG file for the green robot icon (in addition to robot-blue.svg and robot-black.svg that are already in GrowthExperiments)?

@RHo @mepps I'm looking at a similar task. If I understand correctly, the OOUI icon library specifies the color of the icon as well and that only has blue/progressive and black. Would we need a new SVG file for the green robot icon (in addition to robot-blue.svg and robot-black.svg that are already in GrowthExperiments)?

That's a good point @mewoph - I am guessing the answer is yes to making another robot-green30.svg (until changing icons to all palette colours could be made possible in a future version of the Wikimedia UI library is made possible, but that definitely not near term).

Change 666968 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] Add robot icon to task explanation on homepage

https://gerrit.wikimedia.org/r/666968

@RHo I was reviewing the patch from @mepps and noticed that the ribbon behind the difficulty indicator is a different shade in Figma than what we currently have in production, and the Figma version seems to be a little less tall. It also looks like the time estimate label is a slightly different shade.

image.png (370×630 px, 63 KB)

image.png (370×630 px, 42 KB)

Could you please confirm that those changes should be made?

@RHo I was reviewing the patch from @mepps and noticed that the ribbon behind the difficulty indicator is a different shade in Figma than what we currently have in production, and the Figma version seems to be a little less tall. It also looks like the time estimate label is a slightly different shade.

image.png (370×630 px, 63 KB)

image.png (370×630 px, 42 KB)

Could you please confirm that those changes should be made?

Hi @kostajh - Actually the tag background colour needs to updated for all the tags per this outstanding bug task T253706 to fix Colour contrast. Let me provide updated styling for the entire ribbon tag on that task instead and we can estimate separately, instead of tying it to this task (since the easy tag is not a new element).

As for the time estimate text colour though, that is the same Green30 (#14866D) as in production.

Production
image.png (264×664 px, 31 KB)
Figma
image.png (224×1 px, 38 KB)

Change 668541 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/GrowthExperiments@master] Add robot icon and AI description to difficultyFilter checkbox

https://gerrit.wikimedia.org/r/668541

Change 666968 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add robot icon to task explanation on homepage

https://gerrit.wikimedia.org/r/666968

Tooltip from the "i" icon: "Adding links is the easiest way to edit. Links allow readers to click on something they want to learn more about. [paragraph break] The AI will suggest links, and you will decide whether to add them to the article."

And as per https://phabricator.wikimedia.org/T268707#6678422 it seems problematic.

For @RHo review (from testwiki wmf.35):

Screen Shot 2021-03-19 at 3.11.26 PM.png (238×737 px, 30 KB)
Screen Shot 2021-03-18 at 6.06.46 PM.png (586×640 px, 67 KB)

Thanks @Etonkovidova. For some reason though I can't see this in betalabs, and also patchdemo didn't seem to work (getting the error below):

image.png (656×1 px, 80 KB)

Regardless, I am inclined to have the addition of the robot icon and paragraph break in the tooltip as a leftovers task – assuming @MMiller_WMF agrees?

Tooltip from the "i" icon: "Adding links is the easiest way to edit. Links allow readers to click on something they want to learn more about. [paragraph break] The AI will suggest links, and you will decide whether to add them to the article."

And as per https://phabricator.wikimedia.org/T268707#6678422 it seems problematic.

For @RHo review (from testwiki wmf.35):

Screen Shot 2021-03-19 at 3.11.26 PM.png (238×737 px, 30 KB)
Screen Shot 2021-03-18 at 6.06.46 PM.png (586×640 px, 67 KB)

Thanks @Etonkovidova. For some reason though I can't see this in betalabs, and also patchdemo didn't seem to work (getting the error below):

image.png (656×1 px, 80 KB)

For betalabs, which wiki did you check? I see it on https://cs.wikipedia.beta.wmflabs.org/w/index.php?title=Speci%C3%A1ln%C3%AD:Domovsk%C3%A1_str%C3%A1nka&source=personaltoolslink&namespace=-1

For patchdemo, make sure you select "Custom" and then also check the box for "GrowthExperiments" farther down:

image.png (112×1 px, 18 KB)

Thanks @Etonkovidova. For some reason though I can't see this in betalabs, and also patchdemo didn't seem to work (getting the error below):

image.png (656×1 px, 80 KB)

For betalabs, which wiki did you check? I see it on https://cs.wikipedia.beta.wmflabs.org/w/index.php?title=Speci%C3%A1ln%C3%AD:Domovsk%C3%A1_str%C3%A1nka&source=personaltoolslink&namespace=-1

I checked CS beta, but am now realising I might be in the control group still getting the unstructured links task. Is there a console control to switch over?

For patchdemo, make sure you select "Custom" and then also check the box for "GrowthExperiments" farther down:

image.png (112×1 px, 18 KB)

Ah will do, thanks!

I checked CS beta, but am now realising I might be in the control group still getting the unstructured links task. Is there a console control to switch over?

There is no A/B test set up yet, just two identically named task types, and you have to choose the second one in the filter dialog.

I checked CS beta, but am now realising I might be in the control group still getting the unstructured links task. Is there a console control to switch over?

There is no A/B test set up yet, just two identically named task types, and you have to choose the second one in the filter dialog.

Ah got it now, thanks @Tgr!

@MMiller I am going to go ahead and create the leftovers task for the robot icon and paragraph break in the info pop-up since this is not critical, since there's a robot icon on the suggested edits module itself, and the pop-up talks about the AI/Algorithm so combined there is sufficient info here.

image.png (846×1 px, 447 KB)

Thanks @Etonkovidova. For some reason though I can't see this in betalabs, and also patchdemo didn't seem to work (getting the error below):

image.png (656×1 px, 80 KB)

Regardless, I am inclined to have the addition of the robot icon and paragraph break in the tooltip as a leftovers task – assuming @MMiller_WMF agrees?

Tooltip from the "i" icon: "Adding links is the easiest way to edit. Links allow readers to click on something they want to learn more about. [paragraph break] The AI will suggest links, and you will decide whether to add them to the article."

And as per https://phabricator.wikimedia.org/T268707#6678422 it seems problematic.

For @RHo review (from testwiki wmf.35):

Screen Shot 2021-03-19 at 3.11.26 PM.png (238×737 px, 30 KB)
Screen Shot 2021-03-18 at 6.06.46 PM.png (586×640 px, 67 KB)

Resolving as lower incomplete parts have been moved to T278159