Page MenuHomePhabricator
Create Task
Maniphest T268714

RevisionDeleter::checkRevisionExistence is unused
Closed, ResolvedPublic
Actions

Description

As far as I can tell, the only use was removed in rMW0344ea9ffff1: * (bug 21279) Special:RevisionDelete now uses revision ID for deleted-page… back in 2011 as part of T23279: Regular deletion of revisions deleted with rev_deleted breaks links in log entries
Suggest removing the method (either with or without a deprecation period)

Codesearch: https://codesearch.wmcloud.org/search/?q=checkRevisionExistence&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove RevisionDeleter::checkRevisionExistencemediawiki/coremaster+2 -26
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Nov 25 2020, 5:23 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptNov 25 2020, 5:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Nov 25 2020, 5:24 AM
DannyS712 updated the task description. (Show Details)
• Clarakosi triaged this task as Low priority.Dec 1 2020, 9:18 PM
• Clarakosi edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
• Clarakosi moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
• Clarakosi subscribed.

Sounds good to us. @DannyS712 feel free to pick up

gerritbot added a comment.Dec 1 2020, 9:42 PM

Change 644500 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove RevisionDeleter::checkRevisionExistence

https://gerrit.wikimedia.org/r/644500

gerritbot added a project: Patch-For-Review.Dec 1 2020, 9:42 PM
DannyS712 claimed this task.Dec 1 2020, 9:43 PM
DannyS712 edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).
DannyS712 moved this task from Reports to Awaiting review and deployment on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (External Code Reviews).
In T268714#6661082, @Clarakosi wrote:

Sounds good to us. @DannyS712 feel free to pick up

Patch sent, not going through deprecation since its entirely unused

(didn't realize adding external code reviews would removed clinic duty team, switching back)

gerritbot added a comment.Dec 2 2020, 8:07 AM

Change 644500 merged by jenkins-bot:
[mediawiki/core@master] Remove RevisionDeleter::checkRevisionExistence

https://gerrit.wikimedia.org/r/644500

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 8:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 9:00 AM
DannyS712 closed this task as Resolved.Dec 2 2020, 1:43 PM
• Clarakosi moved this task from Later to Done on the Platform Team Workboards (Clinic Duty Team) board.Dec 2 2020, 4:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits