Maniphest T268745

Display prettified IP addresses in Special:Investigate
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Nov 25 2020, 1:35 PM

Tags

Referenced Files

	F33924023: special_investigate.png
	Nov 25 2020, 1:35 PM

Subscribers

Description

From T267015#6645323:

IP addresses in Special:Investigate should be passed through IPUtils::prettifyIP before being displayed to the user.

Example where this doesn't happen:

Note the mixture of upper and lower case (should be lower).

Details

	Subject	Repo	Branch	Lines +/-
	Prettify IP before displaying it	mediawiki/extensions/CheckUser	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T267015: Normalise IP address when checking if IP address in response matches
Mentioned Here: T267015: Normalise IP address when checking if IP address in response matches

Event Timeline

Tchanders created this task.Nov 25 2020, 1:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2020, 1:35 PM

Tchanders updated the task description. (Show Details)Nov 25 2020, 1:44 PM

Tchanders mentioned this in T267015: Normalise IP address when checking if IP address in response matches.

STran claimed this task.Jan 4 2021, 10:07 PM

Change 654363 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/CheckUser@master] Prettify IP before displaying it

https://gerrit.wikimedia.org/r/654363

gerritbot added a project: Patch-For-Review.Jan 5 2021, 2:41 AM

Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.Jan 7 2021, 3:34 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.

Change 654363 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Prettify IP before displaying it

https://gerrit.wikimedia.org/r/654363

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 7 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2021, 4:10 PM

Niharika closed this task as Resolved.Jan 11 2021, 11:34 PM