Page MenuHomePhabricator
Create Task
Maniphest T268787

Table of contents reflows when loading
Closed, ResolvedPublic
Actions

Description

The table of contents when loaded on https://en.m.wikipedia.org/wiki/Hollis_Township,_Peoria_County,_Illinois causes the first heading to jump down like so:

This is a performance issue as it requires an unnecessary re-rendering of the entire page layout and can be a nuisance to users by impacting scroll behaviour position.

Luckily it should be relatively straightforward to address.

QA

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit

QA Results - Beta

ACStatusDetails
1✅T268787#6892222

QA Results - Prod

ACStatusDetails
1✅T268787#6914164

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuemaster+24 -5Table of contents should not trigger reflows in layout
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Nov 25 2020, 8:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2020, 8:06 PM
gerritbot added a comment.Nov 25 2020, 8:06 PM

Change 643542 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Table of contents should not trigger reflows in layout

https://gerrit.wikimedia.org/r/643542

gerritbot added a project: Patch-For-Review.Nov 25 2020, 8:06 PM
PatchDemoBot added a comment.Dec 1 2020, 12:25 PM

Test wiki created on Patch Demo by GDubuc (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/cc7c44b42093adb07e8c5c3a34aeab1c/w/

Jdlrobson added a project: Readers-Web-Backlog.Dec 2 2020, 4:35 PM
Jdlrobson assigned this task to ovasileva.Dec 10 2020, 7:54 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
ovasileva triaged this task as Medium priority.Jan 18 2021, 10:31 PM
ovasileva moved this task from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.
PatchDemoBot added a comment.Jan 19 2021, 9:49 AM

Test wiki created on Patch Demo by GDubuc (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/ddbe31f407db16214ed56e1451e11c0a/w/

Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Readers-Web-Backlog board.Jan 21 2021, 9:16 PM
Jdlrobson updated the task description. (Show Details)Feb 2 2021, 8:56 PM
Jdlrobson updated the task description. (Show Details)
ovasileva edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog.Feb 2 2021, 10:39 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Feb 5 2021, 5:23 PM
Jdlrobson removed ovasileva as the assignee of this task.Mar 3 2021, 6:57 PM
Jdlrobson added a subscriber: ovasileva.
gerritbot added a comment.Mar 3 2021, 10:08 PM

Change 643542 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Table of contents should not trigger reflows in layout

https://gerrit.wikimedia.org/r/643542

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2021, 10:10 PM
Jdlrobson assigned this task to Edtadros.Mar 3 2021, 10:11 PM
Jdlrobson moved this task from Upcoming to Needs QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson updated the task description. (Show Details)Mar 3 2021, 10:49 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 3 2021, 11:00 PM
Edtadros moved this task from Needs QA to Needs QA in Prod on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.Mar 8 2021, 2:52 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit
✅ AC1: When loaded, the table of contents should not cause the first heading to move.

MobileDesktop
Edtadros updated the task description. (Show Details)Mar 8 2021, 2:53 PM
Edtadros reassigned this task from Edtadros to ovasileva.Mar 15 2021, 3:54 PM
Edtadros moved this task from Needs QA in Prod to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit
✅ AC1: When loaded, the table of contents should not cause the first heading to move.

MobileDesktop
Edtadros updated the task description. (Show Details)Mar 15 2021, 3:55 PM
ovasileva closed this task as Resolved.Mar 17 2021, 5:12 PM

All done, resolving

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL