Page MenuHomePhabricator

Table of contents reflows when loading
Closed, ResolvedPublic

Description

The table of contents when loaded on https://en.m.wikipedia.org/wiki/Hollis_Township,_Peoria_County,_Illinois causes the first heading to jump down like so:

bug.gif (434×1 px, 48 KB)

This is a performance issue as it requires an unnecessary re-rendering of the entire page layout and can be a nuisance to users by impacting scroll behaviour position.

Luckily it should be relatively straightforward to address.

QA

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit

QA Results - Beta

ACStatusDetails
1T268787#6892222

QA Results - Prod

ACStatusDetails
1T268787#6914164

Event Timeline

Change 643542 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Table of contents should not trigger reflows in layout

https://gerrit.wikimedia.org/r/643542

Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: ovasileva.

Change 643542 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Table of contents should not trigger reflows in layout

https://gerrit.wikimedia.org/r/643542

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit
✅ AC1: When loaded, the table of contents should not cause the first heading to move.

MobileDesktop
Screen Recording 2021-03-08 at 6.44.18 AM.mov.gif (1×966 px, 217 KB)
Screen Recording 2021-03-08 at 6.48.00 AM.mov.gif (1×966 px, 261 KB)
Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

https://en.m.wikipedia.beta.wmflabs.org/wiki/Tabitha_Twitchit
✅ AC1: When loaded, the table of contents should not cause the first heading to move.

MobileDesktop
Screen Recording 2021-03-15 at 8.51.15 AM.mov.gif (1×830 px, 420 KB)
Screen Recording 2021-03-15 at 8.52.03 AM.mov.gif (1×830 px, 346 KB)

All done, resolving