Page MenuHomePhabricator
Create Task
Maniphest T268829

WikibaseLexeme: Replace wikibase-codesniffer with mediawiki-codesniffer v33
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Enable SpaceAfterClosure sniffmediawiki/extensions/WikibaseLexememaster+41 -45
Remove comment about phpcs metricsmediawiki/extensions/WikibaseLexememaster+0 -3
Partially enable SpaceBeforeSingleLineComment sniffmediawiki/extensions/WikibaseLexememaster+23 -25
Remove unused phpcs exclusionmediawiki/extensions/WikibaseLexememaster+0 -4
Remove redundant phpcs rulesmediawiki/extensions/WikibaseLexememaster+0 -6
Enable FullQualifiedClassName sniffmediawiki/extensions/WikibaseLexememaster+36 -15
Enable ClassLevelLicense sniffmediawiki/extensions/WikibaseLexememaster+26 -0
Replace wikibase-codesniffer with mediawiki-codesniffermediawiki/extensions/WikibaseLexememaster+78 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Nov 26 2020, 1:54 PM
ItamarWMDE mentioned this in T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 26 2020, 2:15 PM
Silvan_WMDE claimed this task.Dec 1 2020, 9:45 AM
Silvan_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644520 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644520

gerritbot added a project: Patch-For-Review.Dec 1 2020, 1:52 PM

Change 644521 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Enable FullQualifiedClassName sniff

https://gerrit.wikimedia.org/r/644521

gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644523 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644523

gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644524 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644524

gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644525 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Remove comment about phpcs metrics

https://gerrit.wikimedia.org/r/644525

gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644526 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Partially enable SpaceBeforeSingleLineComment sniff

https://gerrit.wikimedia.org/r/644526

gerritbot added a comment.Dec 1 2020, 1:52 PM

Change 644527 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Enable SpaceAfterClosure sniff

https://gerrit.wikimedia.org/r/644527

gerritbot added a comment.Dec 1 2020, 1:53 PM

Change 644522 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/WikibaseLexeme@master] Enable ClassLevelLicense sniff

https://gerrit.wikimedia.org/r/644522

Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 1 2020, 2:39 PM
gerritbot added a comment.Dec 1 2020, 3:20 PM

Change 644520 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace wikibase-codesniffer with mediawiki-codesniffer

https://gerrit.wikimedia.org/r/644520

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644521 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable FullQualifiedClassName sniff

https://gerrit.wikimedia.org/r/644521

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644522 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable ClassLevelLicense sniff

https://gerrit.wikimedia.org/r/644522

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644523 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove unused phpcs exclusion

https://gerrit.wikimedia.org/r/644523

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644524 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove redundant phpcs rules

https://gerrit.wikimedia.org/r/644524

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644525 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove comment about phpcs metrics

https://gerrit.wikimedia.org/r/644525

gerritbot added a comment.Dec 1 2020, 3:24 PM

Change 644526 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Partially enable SpaceBeforeSingleLineComment sniff

https://gerrit.wikimedia.org/r/644526

gerritbot added a comment.Dec 1 2020, 3:26 PM

Change 644527 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable SpaceAfterClosure sniff

https://gerrit.wikimedia.org/r/644527

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 1 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2020, 4:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 1 2020, 4:42 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits