Page MenuHomePhabricator

[Wikit] Disabled components should display disabled labels
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently, the font color of labels is not altered whenever a component is disabled. Labels should display a disabled style in order to make more clear to users that the component is not available for interaction.

To Reproduce:

  1. In the Wikit storybook, go to the TextInput component page (In production: https://wmde.github.io/wikit/?path=/story/vue_input-textinput--all)
  2. Observe that the label for the second TextInput (disabled state) is still dark

ACs ๐Ÿ•๏ธ๐ŸŒŸ:

  • When a component that is accompanied by a label (e.g. text input, dropdown, lookup, etc) is disabled, its label should also display a disabled state.

Notes:

  • The Label.json file should include the token font-color-disabled: {font.color.disabled.value}, to be used in the label mixin
  • Special thanks to @ECohen_WMDE for catching this ๐Ÿ™๐Ÿป

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald Transcript

Prio Notes:

  • This issue does not affect developer workflow.
  • This issue affects a running hike.
  • This issue affects consumers of interfaces created with the DS.
ItamarWMDE renamed this task from Disabled components should display disabled labels to [Wikit] Disabled components should display disabled labels.May 11 2021, 11:22 AM
ItamarWMDE added a subscriber: ECohen_WMDE.
Addshore set the point value for this task to 2.May 12 2021, 10:24 AM
Addshore added a subscriber: Addshore.

Looks good!