Page MenuHomePhabricator

phan/phan-taint-check-plugin issues on Parsoid/REL1_35
Closed, DuplicatePublic

Description

Seen via https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/643791 on https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php73-noselenium-docker/3663/console

00:51:43 ERROR: Error: Undefined constant 'ast\AST_LIST' in /workspace/src/services/parsoid/vendor/mediawiki/phan-taint-check-plugin/src/TaintednessBaseVisitor.php:972
00:51:43 Stack trace:
00:51:43 #0 /workspace/src/services/parsoid/vendor/mediawiki/phan-taint-check-plugin/src/TaintednessVisitor.php(527): TaintednessVisitor->getPhanObjsForNode(Object(ast\Node))
00:51:43 #1 /workspace/src/services/parsoid/vendor/mediawiki/phan-taint-check-plugin/src/MWVisitor.php(834): TaintednessVisitor->visitAssign(Object(ast\Node))
00:51:43 #2 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Plugin/ConfigPluginSet.php(1165): MWVisitor->visitAssign(Object(ast\Node))
00:51:43 #3 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Plugin/ConfigPluginSet.php(1093): MWVisitor::Phan\Plugin\{closure}(Object(Phan\CodeBase), Object(Phan\Language\Context), Object(ast\Node), Array)
00:51:43 #4 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Plugin/ConfigPluginSet.php(295): Phan\Plugin\ConfigPluginSet::Phan\Plugin\{closure}(Object(Phan\CodeBase), Object(Phan\Language\Context), Object(ast\Node), Array)
00:51:43 #5 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(2497): Phan\Plugin\ConfigPluginSet->postAnalyzeNode(Object(Phan\CodeBase), Object(Phan\Language\Context), Object(ast\Node), Array)
00:51:43 #6 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(544): Phan\BlockAnalysisVisitor->postOrderAnalyze(Object(Phan\Language\Context), Object(ast\Node))
00:51:43 #7 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/AST/Visitor/KindVisitorImplementation.php(69): Phan\BlockAnalysisVisitor->visit(Object(ast\Node))
00:51:43 #8 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(572): Phan\AST\Visitor\KindVisitorImplementation->visitAssign(Object(ast\Node))
00:51:43 #9 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(233): Phan\BlockAnalysisVisitor->analyzeAndGetUpdatedContext(Object(Phan\Language\Context), Object(ast\Node), Object(ast\Node))
00:51:43 #10 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(572): Phan\BlockAnalysisVisitor->visitStmtList(Object(ast\Node))
00:51:43 #11 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(2378): Phan\BlockAnalysisVisitor->analyzeAndGetUpdatedContext(Object(Phan\Language\Context), Object(ast\Node), Object(ast\Node))
00:51:43 #12 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(572): Phan\BlockAnalysisVisitor->visitMethod(Object(ast\Node))
00:51:43 #13 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(233): Phan\BlockAnalysisVisitor->analyzeAndGetUpdatedContext(Object(Phan\Language\Context), Object(ast\Node), Object(ast\Node))
00:51:43 #14 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(572): Phan\BlockAnalysisVisitor->visitStmtList(Object(ast\Node))
00:51:43 #15 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(1337): Phan\BlockAnalysisVisitor->analyzeAndGetUpdatedContext(Object(Phan\Language\Context), Object(ast\Node), Object(ast\Node))
00:51:43 #16 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(2346): Phan\BlockAnalysisVisitor->visitClosedContext(Object(ast\Node))
00:51:43 #17 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(572): Phan\BlockAnalysisVisitor->visitClass(Object(ast\Node))
00:51:43 #18 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/BlockAnalysisVisitor.php(233): Phan\BlockAnalysisVisitor->analyzeAndGetUpdatedContext(Object(Phan\Language\Context), Object(ast\Node), Object(ast\Node))
00:51:43 #19 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/AST/Visitor/KindVisitorImplementation.php(35): Phan\BlockAnalysisVisitor->visitStmtList(Object(ast\Node))
00:51:43 #20 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Analysis.php(560): Phan\AST\Visitor\KindVisitorImplementation->__invoke(Object(ast\Node))
00:51:43 #21 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Phan.php(526): Phan\Analysis::analyzeFile(Object(Phan\CodeBase), 'src/Config/Api/...', NULL, NULL)
00:51:43 #22 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Phan.php(583): Phan\Phan::Phan\{closure}(0, 'src/Config/Api/...', 229)
00:51:43 #23 /workspace/src/services/parsoid/vendor/phan/phan/src/Phan/Phan.php(376): Phan\Phan::finishAnalyzingRemainingStatements(Object(Phan\CodeBase), NULL, Array, Array)
00:51:43 #24 /workspace/src/services/parsoid/vendor/phan/phan/src/phan.php(36): Phan\Phan::analyzeFileList(Object(Phan\CodeBase), Object(Closure))
00:51:43 #25 /workspace/src/services/parsoid/vendor/phan/phan/phan(9): require_once('/workspace/src/...')
00:51:43 #26 {main}
00:51:43 (Phan 2.6.1 crashed due to an uncaught Throwable when parsing/analyzing 'src/Config/Api/ApiHelper.php')
00:51:44 Script phan -p --allow-polyfill-parser --config-file=.phan/standalone.php --long-progress-bar handling the phan event returned with error code 1
00:51:44 Script @phan was called via test