Page MenuHomePhabricator
Create Task
Maniphest T268863

Translate uses Elastica's Match class
Closed, ResolvedPublic
Actions

Description

Similar to T268861: CirrusSearch uses Elastica's Match class and T268862: Update use of css-sanitizers Match class; Translate uses Elastica's Match class in ElasticSearchTTMServer

I note the MediaWiki Language Extension Bundle/translate support here might be a problem.

The replacement MatchQuery class is now in master, and backported to 1.35.... But it's not in 1.34 (of Elastica); but that is EOL for most purposes.

We could just backport rEELA290255cc67b0: Update ruflin/elastica to 6.1.1 and then rEELA65ac9f8baa7b: Updating ruflin/elastica (6.1.1 => 6.1.3) to 1.34 if it's needed..

Or if the next release of MLEB is going to require MW >= 1.35, we don't need to worry about this anyway

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/TranslateREL1_36+1 -1Replace Elastica\Query\Match with Elastica\Query\MatchQuery
mediawiki/extensions/TranslateREL1_35+1 -1Replace Elastica\Query\Match with Elastica\Query\MatchQuery
mediawiki/extensions/Translatemaster+1 -1Replace Elastica\Query\Match with Elastica\Query\MatchQuery
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReedyT268863 Translate uses Elastica's Match class
 ResolvedEBernhardsonT271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0
 ResolvedGehelT263142 [EPIC] Upgrade Elasticsearch to version 7.10
 ResolvedEBernhardsonT218994 Deprecation warning on elasticsearch 6
ResolvedEBernhardsonT218995 re-enable deprecation warning logger on elasticsearch once issues are solved
 ResolveddcausseT219265 Elasticsearch 6: _retry_on_conflict is deprecated
 ResolveddcausseT219266 Elasticsearch 6 nested_path and nested_filter are deprecated
 ResolveddcausseT219267 Elasticsearch 6: auto_generate_phrase_queries is deprecated and ineffective
 ResolveddcausseT219268 Elasticsearch 6: the classic similarity is deprecated
 ResolveddcausseT219533 Reindex space less languages wikis to use BM25
 OpenNoneT219534 Test MLR models for zhwiki, jawiki and kowiki
 ResolvedEBernhardsonT219269 Elasticsearch 6: silence deprecation warnings to avoid logspam
 DuplicateNoneT215615 Stop using negative scores for deboosting statements
 ResolvedEBernhardsonT288764 Set include_type_name in all get requests
 Resolved• EJosephT288765 Always provide minimum_should_match in bool queries
 ResolvedEBernhardsonT306123 Ensure mjolnir models have positive scores
 DuplicateNoneT273814 Create ElasticSearch 7.10 image in releng/dev-images
 ResolvedGehelT295666 Upgrade Cirrus elasticsearch clusters to 6.8.23
 Resolved• EJosephT294499 Upgrade Cirrus elasticsearch plugins to 6.8.23
 ResolvedbkingT301954 Upgrade deployment-prep to elasticsearch 6.8.23
 ResolvedbkingT301955 Upgrade relforge to elasticsearch 6.8.23
 ResolvedRKemperT278378 Pull Elasticsearch config out of Spicerack
 ResolvedRKemperT301956 Upgrade cloudelastic to elasticsearch 6.8.23
 ResolvedRKemperT301958 Upgrade Search elasticsearch cluster / codfw to elasticsearch 6.8.23
 ResolvedRKemperT301959 Upgrade Search elasticsearch cluster / eqiad to elasticsearch 6.8.23
 ResolvedGehelT304570 elasticsearch: make rolling upgrade proceed to second host after shards are stable
 ResolvedbkingT289135 Upgrade Cirrus Elasticsearch clusters to Debian Bullseye
 ResolvedbkingT299797 Deploy new bullseye elastic cluster nodes on deployment-prep
 ResolvedbkingT301408 Enable search team SRE access to deployment-prep VMs
 ResolvedbkingT307510 Update tls proxy config for Bullseye
 ResolvedbkingT308770 Reimage relforge elastic hosts from Stretch to Bullseye
 ResolvedbkingT309343 Upgrade cloudelastic clusters to Debian Bullseye
 ResolvedbkingT312298 Update NIC firmware on all Elastic PowerEdge R440 elastic hosts
 ResolvedEBernhardsonT295736 Evaluate deployed elasticsearch plugins for 7.10 compatability
 ResolvedEBernhardsonT295734 Bring up two copies of the CirrusSearch browser integration env in cloud
 ResolvedTJonesT300302 Test Elastic 6.8 language analyzers
 Resolved• ZbyszkoT300833 Address "Log4shell" vulnerability in Elasticsearch 7.10.2
 DeclinedNoneT301724 Sunset ApiFeatureUsage
 DeclinedNoneT302638 Sunset ApiFeatureUsage (TDMP)
 ResolvedTJonesT301131 Test Elastic 7.10 language analyzers
 ResolvedEBernhardsonT317200 Reindex all wikis to fix nnbsp regression
 DeclinedNoneT303443 Ensure that all applications depending on the Search Elasticsearch cluster are compatible with Elasticsearch 7.10
 Resolved• bd808T303444 Ensure Toolhub is compatible with Elasticsearch 7.10
 DeclinedNoneT303445 Ensure Phabricator is compatible with Elasticsearch 7.10
 ResolvedEBernhardsonT304290 Create docker elasticsearch images with wmf search plugins
 DeclinedNoneT304569 Remove row/rack awareness in Elasticsearch config
 ResolveddcausseT305428 Upgrade the Translate TTM Elasticsearch implementation to elasticsearch 6.8 and onwards
ResolvedEBernhardsonT306644 re-run wbsearchentities optimization process
ResolvedEBernhardsonT307931 Run CirrusSearch test suite against Elasticsearch 7.10
 ResolvedEBernhardsonT308676 Elasticsearch 7.10.2 rollout plan
 ResolvedbkingT315604 Upgrade relforge cluster to 7.10.2
 ResolvedGehelT316159 Upgrade cloudelastic cluster to 7.10.2
 ResolvedGehelT316240 Upgrade deployment-prep to Elasticsearch 7.10.2
 ResolvedRKemperT316719 Upgrade codfw cluster to Elasticsearch 7.10.2
 ResolvedBUG REPORTEBernhardsonT317381 Reduction in helpfulness and quantity of autocomplete search results
 ResolvedEBernhardsonT317374 Search now caps total results count at 10k because of elasticsearch 7 upgrade
 ResolvedRKemperT317686 Upgrade eqiad cluster to Elasticsearch 7.10.2
 ResolvedEBernhardsonT313434 Migrate apifeatureusage to elasticsearch 7
 ResolvedkostajhT317513 Flow is incompatible with Elastica - Remove ElasticSearch integration / Flow search
 ResolvedReedyT274877 Update ruflin/elastica to 6.1.3

Event Timeline

Reedy created this task.Nov 27 2020, 1:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2020, 1:38 AM
Reedy mentioned this in T268861: CirrusSearch uses Elastica's Match class.Nov 27 2020, 4:21 AM
Reedy moved this task from Backlog to Other on the PHP 8.0 support board.Dec 8 2020, 2:58 AM
Reedy moved this task from Other to Wikimedia production on the PHP 8.0 support board.
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Dec 15 2020, 10:44 AM
Reedy added a subtask: T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0.Jan 12 2021, 8:44 AM
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Open to Stalled.Feb 7 2021, 12:28 AM
Reedy changed the task status from Open to Stalled.Feb 7 2021, 12:29 AM
Reedy added a subtask: T274877: Update ruflin/elastica to 6.1.3.Feb 16 2021, 11:51 AM
Reedy closed subtask T274877: Update ruflin/elastica to 6.1.3 as Resolved.Mar 6 2021, 6:36 PM
Reedy changed the task status from Stalled to Open.Mar 6 2021, 6:37 PM
Reedy updated the task description. (Show Details)Mar 6 2021, 6:50 PM
Nikerabbit added a subscriber: Nikerabbit.Mar 7 2021, 7:50 AM

Looking at the expected release date for 1.36 (May), the next MLEB (April) will still support 1.34.

Reedy added a comment.Aug 18 2021, 12:40 PM

https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Latest_release

Compatible with MediaWiki 1.35 or above and requires PHP 7.2 or above.

Looks like I should be good to action this now

gerritbot added a comment.Aug 18 2021, 12:44 PM

Change 713629 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@master] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713629

gerritbot added a project: Patch-For-Review.Aug 18 2021, 12:44 PM
gerritbot added a comment.Aug 19 2021, 5:32 AM

Change 713629 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713629

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 19 2021, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 6:10 AM
Reedy closed this task as Resolved.Aug 19 2021, 10:08 AM
Reedy claimed this task.
gerritbot added a comment.Aug 19 2021, 11:00 AM

Change 713846 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@REL1_35] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713846

gerritbot added a project: Patch-For-Review.Aug 19 2021, 11:00 AM

Change 713847 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@REL1_36] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713847

gerritbot added a comment.Aug 19 2021, 11:14 AM

Change 713847 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_36] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713847

gerritbot added a comment.Aug 19 2021, 11:14 AM

Change 713846 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_35] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713846

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 12:10 PM
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Stalled to Open.Oct 8 2021, 2:36 PM
Reedy changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Open to Stalled.Dec 17 2021, 4:52 PM
dcausse changed the status of subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 from Stalled to Open.May 18 2022, 6:41 PM
Jdforrester-WMF closed subtask T271777: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 as Resolved.Aug 30 2022, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL