Page MenuHomePhabricator

Translate uses Elastica's Match class
Closed, ResolvedPublic

Description

Similar to T268861: CirrusSearch uses Elastica's Match class and T268862: Update use of css-sanitizers Match class; Translate uses Elastica's Match class in ElasticSearchTTMServer

I note the MediaWiki Language Extension Bundle/translate support here might be a problem.

The replacement MatchQuery class is now in master, and backported to 1.35.... But it's not in 1.34 (of Elastica); but that is EOL for most purposes.

We could just backport rEELA290255cc67b0: Update ruflin/elastica to 6.1.1 and then rEELA65ac9f8baa7b: Updating ruflin/elastica (6.1.1 => 6.1.3) to 1.34 if it's needed..

Or if the next release of MLEB is going to require MW >= 1.35, we don't need to worry about this anyway

Related Objects

StatusSubtypeAssignedTask
ResolvedReedy
ResolvedEBernhardson
ResolvedGehel
ResolvedEBernhardson
ResolvedEBernhardson
Resolved dcausse
Resolved dcausse
Resolved dcausse
Resolved dcausse
Resolved dcausse
OpenNone
ResolvedEBernhardson
DuplicateNone
ResolvedEBernhardson
ResolvedEJoseph
ResolvedEBernhardson
DuplicateNone
ResolvedGehel
ResolvedEJoseph
Resolvedbking
Resolvedbking
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedRKemper
ResolvedGehel
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
Resolvedbking
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedTJones
Resolved Zbyszko
DeclinedNone
DeclinedJenlenfantwright
ResolvedTJones
ResolvedEBernhardson
DeclinedNone
Resolvedbd808
DeclinedNone
ResolvedEBernhardson
DeclinedNone
Resolved dcausse
ResolvedEBernhardson
ResolvedEBernhardson
ResolvedEBernhardson
Resolvedbking
ResolvedGehel
ResolvedGehel
ResolvedRKemper
ResolvedBUG REPORTEBernhardson
ResolvedEBernhardson
ResolvedRKemper
ResolvedEBernhardson
Resolvedkostajh
ResolvedReedy

Event Timeline

Reedy moved this task from Other to Wikimedia production on the PHP 8.0 support board.
Reedy changed the task status from Open to Stalled.Feb 7 2021, 12:29 AM
Reedy changed the task status from Stalled to Open.Mar 6 2021, 6:37 PM

Looking at the expected release date for 1.36 (May), the next MLEB (April) will still support 1.34.

https://www.mediawiki.org/wiki/MediaWiki_Language_Extension_Bundle#Latest_release

Compatible with MediaWiki 1.35 or above and requires PHP 7.2 or above.

Looks like I should be good to action this now

Change 713629 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@master] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713629

Change 713629 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713629

Reedy claimed this task.

Change 713846 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@REL1_35] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713846

Change 713847 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Translate@REL1_36] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713847

Change 713847 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_36] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713847

Change 713846 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_35] Replace Elastica\\Query\\Match with Elastica\\Query\\MatchQuery

https://gerrit.wikimedia.org/r/713846