Page MenuHomePhabricator
Create Task
Maniphest T268870

Remove Wikibase.NewItemIdFormatter log channel
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Currently we are logging into, Wikibase.NewItemIdFormatter in production. However, this channel is obsolete and therfore needs to be removed.

AC:

  • There are no Loggers registered to Wikibase.NewItemIdFormatter
  • There are no configuration entries associated with Wikibase.NewItemIdFormatter

Occurrences:

Original note:

While looking into Wikibase log channels for T268625, I saw that we still have a Wikibase.NewItemIdFormatter log channel in production, introduced by @Addshore for T201832. I assume it’s obsolete nowadays, and can be totally removed, or at least replaced with the general Wikibase channel, since the new item ID formatter is no longer under active development.

Details

SubjectRepoBranchLines +/-
Remove Wikibase.NewItemIdFormatter log channeloperations/mediawiki-configmaster+0 -2
Remove Wikibase.NewItemIdFormatter log channelmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 27 2020, 7:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 27 2020, 7:29 AM
Addshore awarded a token.Dec 2 2020, 11:04 AM
Addshore updated the task description. (Show Details)Jan 19 2021, 11:10 AM
WMDE-leszek added a project: Wikidata-Campsite.Jan 19 2021, 12:17 PM
WMDE-leszek moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
ItamarWMDE updated the task description. (Show Details)Jan 19 2021, 1:07 PM
darthmon_wmde set the point value for this task to 5.Jan 20 2021, 1:02 PM
darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 20 2021, 1:35 PM
darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 20 2021, 2:15 PM
noarave subscribed.Jan 21 2021, 1:25 PM

Task inspection note:

  • on WikibaseRepo we should log to the general Wikibase channel (LoggerFactory::getInstance( 'Wikibase' );).
  • the logger definition on the wmf-config side can be completely removed
Addshore moved this task from Inbox to Small Code Fixes on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 9:47 PM
Addshore moved this task from Small Code Fixes to legacy-backlog on the [DEPRECATED] wdwb-tech board.Jan 22 2021, 10:39 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.
Addshore moved this task from Incoming to Active on the [DEPRECATED] wdwb-tech (legacy-backlog) board.Jan 22 2021, 11:07 PM
Rosalie_WMDE claimed this task.Jan 25 2021, 12:58 PM
Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 25 2021, 2:07 PM

Change 658310 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove Wikibase.NewItemIdFormatter log channel

https://gerrit.wikimedia.org/r/658310

gerritbot added a project: Patch-For-Review.Jan 25 2021, 2:07 PM
gerritbot added a comment.Jan 25 2021, 3:08 PM

Change 658321 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[operations/mediawiki-config@master] Remove Wikibase.NewItemIdFormatter log channel

https://gerrit.wikimedia.org/r/658321

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 25 2021, 3:14 PM
gerritbot added a comment.Jan 25 2021, 6:19 PM

Change 658310 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove Wikibase.NewItemIdFormatter log channel

https://gerrit.wikimedia.org/r/658310

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 25 2021, 7:00 PM
Lucas_Werkmeister_WMDE added a comment.Jan 26 2021, 10:29 AM

Let’s wait with deploying the config change until the code change is rolled out (Thursday or so), to avoid sending log messages to an unconfigured channel. (I’m not sure if sending logs to an unconfigured channel is actually a bad thing if we don’t care much about the potentially lost messages, but also, there’s no need to rush with this change, I think.)

Lucas_Werkmeister_WMDE added a comment.Feb 10 2021, 11:11 AM

The train is still stuck on wmf.27, and @Addshore claims removing the log channel should not cause any issues, so let’s just do it without waiting any longer for the train.

gerritbot added a comment.Feb 10 2021, 12:14 PM

Change 658321 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove Wikibase.NewItemIdFormatter log channel

https://gerrit.wikimedia.org/r/658321

Stashbot added a comment.Feb 10 2021, 12:18 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-10T12:18:21Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:658321|Remove Wikibase.NewItemIdFormatter log channel (T268870)]] 1/2 (duration: 01m 07s)

Stashbot added a comment.Feb 10 2021, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-10T12:20:03Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:658321|Remove Wikibase.NewItemIdFormatter log channel (T268870)]] 2/2 (prod no-op) (duration: 01m 08s)

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 10 2021, 12:21 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2021, 1:10 PM
Addshore closed this task as Resolved.Feb 24 2021, 11:52 AM

codesearch and patches looks good!

noarave moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 26 2021, 12:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits