Page MenuHomePhabricator
Create Task
Maniphest T268928

Drop support for PHP < 7.0 and HHVM
Closed, ResolvedPublic
Actions

Description

LuaSandbox has various compiler conditionals for various ancient versions of PHP

We don't care about PHP < 7.0 (or even < 7.2 these days), nor do we care about HHVM support

Details

SubjectRepoBranchLines +/-
Drop HHVM supportmediawiki/php/luasandboxmaster+3 -160
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Nov 29 2020, 1:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2020, 1:07 AM
Reedy added a comment.Nov 30 2020, 3:04 AM

https://gerrit.wikimedia.org/r/c/mediawiki/php/luasandbox/+/644052/ drops most of the PHP 5 support; was tagged against T268925: Luasandbox fails to compile with PHP 8.0

gerritbot added a comment.Jan 8 2021, 2:03 AM

Change 654963 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/php/luasandbox@master] WIP: Drop HHVM support

https://gerrit.wikimedia.org/r/654963

gerritbot added a project: Patch-For-Review.Jan 8 2021, 2:03 AM
gerritbot added a comment.Jan 8 2021, 3:23 PM

Change 654963 merged by jenkins-bot:
[mediawiki/php/luasandbox@master] Drop HHVM support

https://gerrit.wikimedia.org/r/654963

Reedy closed this task as Resolved.Jan 8 2021, 3:23 PM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL