Page MenuHomePhabricator
Create Task
Maniphest T268999

Show medium size (<320 wide, but >=250 high) images as well
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
thiemowmde
Nov 30 2020, 2:15 PM
Tags
Referenced Files
F34621135: Screen Shot 2021-08-26 at 2.33.16 PM.png
Aug 26 2021, 9:35 PM
F34591810: Screen Shot 2021-08-12 at 7.46.50 AM.png
Aug 12 2021, 2:53 PM
F34570836: Screen Shot 2021-07-30 at 3.43.01 PM.png
Jul 30 2021, 9:43 PM
F34570834: Screen Shot 2021-07-30 at 3.30.20 PM.png
Jul 30 2021, 9:42 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
cjming
Edtadros
Jdlrobson
Lena_WMDE
View All 10 Subscribers
Tokens
"Love" token, awarded by alexhollender_WMF.

Description

The requirement for landscape images is to be at least 320px wide. The requirement for portrait images is more relaxed, only 250px high. Images that fall between these two requirements currently don't show a thumbnail, even if they could.

This request is about a very specific group of images:

  • Square images from 250 x 250 to 319 x 319.
  • Landscape images from 251 x 250 to 319 x 250.
  • Landscape images from 319 x 250 to 319 x 318.

All these could be shown in portrait mode.

In this group, the most extrem ratio is 319 x 250. This will be cut to 203 x 250. I.e. the absolute extreme are 58px missing left and right, but never more.

Requested at https://www.mediawiki.org/wiki/Topic:Vwl97pm6as9fuf6k.

QA

Use patchdemo for verifying this in beta.

Expected: a preview shows.

Screen Shot 2021-07-30 at 3.30.20 PM.png (1×2 px, 1 MB)

Compare to prod - https://en.wikipedia.org/wiki/Sonic_Adventure_2

Screen Shot 2021-07-30 at 3.43.01 PM.png (1×1 px, 486 KB)

Patch-For-Review: https://gerrit.wikimedia.org/r/636629

QA Results - Patchdemo

ACStatusDetails
1✅T268999#7279046

QA Results - Prod

ACStatusDetails
1✅T268999#7313465

Details

SubjectRepoBranchLines +/-
DNM: Patchdemo purposes onlymediawiki/coremaster+6 -0
Show medium size (<320 wide, but >=250 high) images as wellmediawiki/extensions/Popupsmaster+162 -49
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jan 28 2021, 4:45 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
ovasileva moved this task from Code Review to Needs Analysis on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 1 2021, 6:12 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 12 2021, 6:40 PM
Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 19 2021, 9:09 PM
thiemowmde added a comment.Feb 23 2021, 7:53 AM

Here are 2 more users wondering why certain images don't appear in Page-Previews: https://www.mediawiki.org/wiki/Topic:Viyfrnik5ttdq69e. While the patch discussed here can't solve all of this (some images are just to small, no matter what), the patch will relax the situation a bit.

LGoto lowered the priority of this task from Medium to Low.Feb 24 2021, 6:13 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 24 2021, 9:27 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).Mar 1 2021, 6:13 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Mar 4 2021, 9:47 PM
thiemowmde added a project: WMDE-TechWish.Mar 5 2021, 2:46 PM
thiemowmde added a subscriber: Lena_WMDE.

@Lena_WMDE, I would love to explain this in our story time and later put this in our sprint. Code-wise it's a tiny change. Not only do 3rd parties benefit, it also improves the experience on the Wikimedia cluster.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Tracking).May 14 2021, 3:11 PM
Jdlrobson added a subscriber: ovasileva.

This patch has several +1s @ovasileva and has been sitting in our backlog for some time. SInce we last looked at it, a storybook entry has been added which significantly de-riskes this. Since we are planning on looking at T281170 it makes sense to look at this one too.

Jdlrobson moved this task from Needs More Work to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 14 2021, 3:11 PM
Jdlrobson added a parent task: T284095: [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter.Jun 1 2021, 5:22 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).

Bumping to backlog. We'll focus on this as part of T284095 .

Jdlrobson moved this task from Needs Prioritization to unsed on the Web-Team-Backlog board.Jun 11 2021, 4:44 PM
Jdlrobson moved this task from unsed to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jun 30 2021, 3:32 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
LGoto set the point value for this task to 3.Jul 12 2021, 5:38 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming claimed this task.Jul 15 2021, 10:01 PM
cjming moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming removed cjming as the assignee of this task.Jul 22 2021, 3:56 PM
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming subscribed.
cjming claimed this task.Jul 22 2021, 4:26 PM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming removed cjming as the assignee of this task.Jul 24 2021, 12:31 AM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson merged a task: T287446: No Image Preview displayed for certain links.Jul 27 2021, 2:29 PM
Jdlrobson added a subscriber: Shadowboxer2005.
LGoto assigned this task to bwang.Jul 27 2021, 5:35 PM
Jdlrobson removed bwang as the assignee of this task.Jul 27 2021, 5:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.
PatchDemoBot added a comment.Jul 27 2021, 9:41 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/45e398653b/w/

Jdlrobson claimed this task.Jul 27 2021, 9:47 PM
Shadowboxer2005 added a comment.Jul 27 2021, 10:53 PM

This may sound stupid, but how do you enable this?

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 27 2021, 11:57 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
cjming claimed this task.Jul 28 2021, 9:43 PM
Aklapper mentioned this in T287750: SVG images in preview render as PNG rather than SVGs.Jul 30 2021, 10:12 AM
cjming removed cjming as the assignee of this task.Jul 30 2021, 8:59 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jul 30 2021, 9:12 PM

Change 709109 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] DNM: Patchdemo purposes only

https://gerrit.wikimedia.org/r/709109

PatchDemoBot added a comment.Jul 30 2021, 9:13 PM

Test wiki on Patch Demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/45e398653b/w/

PatchDemoBot added a comment.Jul 30 2021, 9:16 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/2bf5a93d07/w/

PatchDemoBot added a comment.Jul 30 2021, 9:19 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/9d7f45b4cd/w/

PatchDemoBot added a comment.Jul 30 2021, 9:20 PM

Test wiki on Patch Demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2bf5a93d07/w/

PatchDemoBot added a comment.Jul 30 2021, 9:20 PM

Test wiki on Patch Demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9d7f45b4cd/w/

PatchDemoBot added a comment.Jul 30 2021, 9:25 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/bebc04f502/w/

cjming updated the task description. (Show Details)Jul 30 2021, 9:42 PM
cjming updated the task description. (Show Details)
cjming added a comment.EditedJul 30 2021, 9:48 PM
In T268999#7241317, @Shadowboxer2005 wrote:

This may sound stupid, but how do you enable this?

Do you mean on patchdemo? I just updated the patchdemo link so you should be able to test popups for this ticket's associated patch (plus necessary config) at https://patchdemo.wmflabs.org/wikis/bebc04f502/wiki/Sonic_Adventure_2 for example.

PatchDemoBot added a comment.Jul 31 2021, 6:23 AM

Test wiki created on Patch Demo by Shadowboxer2005 using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/32ebbe2a29/w/

Shadowboxer2005 added a comment.Jul 31 2021, 6:26 AM

Seems to work now.

cjming claimed this task.Aug 2 2021, 9:10 PM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
LGoto edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Kanbanana-FY-2020-21).Aug 2 2021, 9:29 PM
LGoto moved this task from Needs Analysis to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming removed cjming as the assignee of this task.Aug 3 2021, 3:08 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming claimed this task.Aug 3 2021, 4:48 PM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming mentioned this in T287984: Revise terminology for thumbnails and popups in page previews.Aug 3 2021, 7:05 PM
cjming removed cjming as the assignee of this task.Aug 3 2021, 8:02 PM
cjming moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Aug 4 2021, 1:04 AM

Change 636629 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Show medium size (<320 wide, but >=250 high) images as well

https://gerrit.wikimedia.org/r/636629

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 4 2021, 2:00 AM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 4 2021, 12:52 PM
cjming assigned this task to Edtadros.Aug 5 2021, 5:07 PM
Jdlrobson mentioned this in T255549: Portrait images in PagePreview popups are notably cut off (zoomed in).Aug 6 2021, 4:02 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Aug 12 2021, 2:53 PM
Edtadros subscribed.

Status: ✅ PASS
Environment: patchdemo
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Use patchdemo for verifying this in beta.

Visit Sonic Adventure 2 article - i.e. https://patchdemo.wmflabs.org/wikis/bebc04f502/wiki/Sonic_Adventure_2
Hover over "Sonic Adventure" in the bottom navbox.
✅ AC1: Preview matches screenshot in task description above.

Screen Shot 2021-08-12 at 7.46.50 AM.png (837×1 px, 563 KB)

@Jdlrobson will this make it to Beta? There are some boundary values in the task description that we could validate. Not sure how to do it in patchdemo.

Edtadros updated the task description. (Show Details)Aug 12 2021, 2:54 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Aug 19 2021, 10:55 PM
Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

I tested this locally, and it looks like the patchdemo was outdated. Can't replicate the boundary issues locally, so let's call this one a pass. We'll be able to confirm this in production now/tomorrow.

Edtadros reassigned this task from Edtadros to ovasileva.Aug 26 2021, 9:35 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit Sonic Adventure 2 article
Hover over "Sonic Adventure" in the bottom navbox.
✅ AC1: Preview matches screenshot in task description above.

Screen Shot 2021-08-26 at 2.33.16 PM.png (819×1 px, 619 KB)

Edtadros updated the task description. (Show Details)Aug 26 2021, 9:36 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 10:10 PM
ovasileva closed this task as Resolved.Aug 31 2021, 3:48 PM

Looks good!

PatchDemoBot added a comment.Aug 31 2021, 6:03 PM

Test wiki created on Patch Demo by CMing (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/1a4a4e14c0/w/

PatchDemoBot added a comment.Jan 20 2022, 1:37 PM

Test wiki on Patch demo by Shadowboxer2005 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/32ebbe2a29/w/

PatchDemoBot added a comment.Feb 21 2022, 4:01 PM

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bebc04f502/w/

PatchDemoBot added a comment.Feb 21 2022, 4:07 PM

Test wiki on Patch demo by CMing (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1a4a4e14c0/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL