Page MenuHomePhabricator

Show medium size (<320 wide, but >=250 high) images as well
Open, LowPublic

Description

The requirement for landscape images is to be at least 320px wide. The requirement for portrait images is more relaxed, only 250px high. Images that fall between these two requirements currently don't show a thumbnail, even if they could.

This request is about a very specific group of images:

  • Square images from 250 x 250 to 319 x 319.
  • Landscape images from 251 x 250 to 319 x 250.
  • Landscape images from 319 x 250 to 319 x 318.

All these could be shown in portrait mode.

In this group, the most extrem ratio is 319 x 250. This will be cut to 203 x 250. I.e. the absolute extreme are 58px missing left and right, but never more.

Requested at https://www.mediawiki.org/wiki/Topic:Vwl97pm6as9fuf6k.

Patch-For-Review: https://gerrit.wikimedia.org/r/636629

Event Timeline

Change 636629 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Show medium size (<320 wide, but >=250 high) images as well

https://gerrit.wikimedia.org/r/636629

Jdlrobson added subscribers: alexhollender, Jdlrobson.

cc @alexhollender since this concerns design.
Not sure if this should be tagged Readers-Web-Backlog or if @thiemowmde's team will be working on this.

While WMDE worked on the Popups extension – and plans to continue doing so – this here is outside of my team's current scope. So it would be great if you could pick this up!

ovasileva triaged this task as Medium priority.Jan 13 2021, 4:30 PM

Here are 2 more users wondering why certain images don't appear in Page-Previews: https://www.mediawiki.org/wiki/Topic:Viyfrnik5ttdq69e. While the patch discussed here can't solve all of this (some images are just to small, no matter what), the patch will relax the situation a bit.

LGoto lowered the priority of this task from Medium to Low.Feb 24 2021, 6:13 PM
thiemowmde added a subscriber: Lena_WMDE.

@Lena_WMDE, I would love to explain this in our story time and later put this in our sprint. Code-wise it's a tiny change. Not only do 3rd parties benefit, it also improves the experience on the Wikimedia cluster.