Page MenuHomePhabricator
Create Task
Maniphest T269084

Pick a sentence: Disable "Done" button when no section sentence is translated
Closed, ResolvedPublic
Actions

Description

Currently when user enters the "Pick a sentence" screen, "Done" button is already enabled.

image.png (236×419 px, 21 KB)

Because of this user can proceed to the "Preview and Publish" step without having translated any section content.
image.png (386×455 px, 29 KB)

Fix: Disable "Done" button until at least one section sentence is translated.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+5 -0SX Sentence Selector: Disable done button for untranslated sections
Customize query in gerrit

Related Objects

Event Timeline

ngkountas created this task.Dec 1 2020, 9:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2020, 9:08 AM
gerritbot added a comment.Dec 1 2020, 9:13 AM

Change 644463 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Disable done button for untranslated sections

https://gerrit.wikimedia.org/r/644463

gerritbot added a project: Patch-For-Review.Dec 1 2020, 9:13 AM
Pginer-WMF triaged this task as Medium priority.Dec 1 2020, 11:22 AM
Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.
ngkountas mentioned this in T259514: Preview and publish: Preview contents for users to confirm.Dec 1 2020, 12:01 PM
ngkountas moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2020-October-December) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2020-October-December) board.Dec 1 2020, 12:09 PM
gerritbot added a comment.Dec 3 2020, 7:02 AM

Change 644463 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Disable done button for untranslated sections

https://gerrit.wikimedia.org/r/644463

Maintenance_bot removed a project: Patch-For-Review.Dec 3 2020, 7:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 3 2020, 8:00 AM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2020-October-December) board.Dec 17 2020, 4:53 AM
Jpita moved this task from Needs QA to Done on the Language-Team (Language-2020-October-December) board.Dec 17 2020, 5:23 PM
Pginer-WMF closed this task as Resolved.Dec 18 2020, 11:17 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL