Page MenuHomePhabricator

Investigate the effects of apc.enable_cli on the addSite.php maintenance script
Open, MediumPublic

Description

It seems as though the addSite maintenance script does not work well when apc is enabled for MediaWiki (site store caching is enabled) and apc.enable_cli is off.

Prerequisites:
MediaWiki instance with any cache enabledphp.ini setting - apc.enable_cli set to off

Steps to reproduce:

  • Run maintenance/addSite.php
  • Check that the site is visible

Current behavior:
The script does run successfully and adds the site to the database, but the site is not visible as the cache is populated with the old data.

Expected behavior depends on the result of the investigation. The script either warns users that the setting is off, or enables the setting for them (if no adverse effects were detected)

AC:

  • Investigate how changing this setting (apc.enable_cli) affects mediawiki instances
  • Implement a warning to notify users of this script regarding this pitfall OR change the setting from within the script, depending on the outcome of the investigation.

Hints:
@Addshore Created an initial Gerrit change documenting this slightly https://gerrit.wikimedia.org/r/c/mediawiki/core/+/603570

But this probably needs a better method of being tackled as it will and has caught many people out.
This could be:

  • better docs?
  • warnings in the script that this is going to happen?
  • enabling this setting for the script?
  • something else?

Reading:

Event Timeline

Addshore created this task.Dec 1 2020, 10:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2020, 10:36 AM

Change 603570 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Document that addSite won't work well without apc.enable_cli enabled

https://gerrit.wikimedia.org/r/603570

Addshore updated the task description. (Show Details)Dec 1 2020, 11:39 AM
Addshore updated the task description. (Show Details)Dec 1 2020, 11:42 AM
ItamarWMDE renamed this task from addSite maintenance script does not work well when site store caching is enabled and apc.enable_cli is off to Investigate the effects of apc.enable_cli on the addSite.php maintenance script.Tue, Jan 12, 1:32 PM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Tue, Jan 12, 1:37 PM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Tue, Jan 12, 1:40 PM
Rosalie_WMDE updated the task description. (Show Details)Tue, Jan 12, 3:23 PM
Rosalie_WMDE updated the task description. (Show Details)
Addshore updated the task description. (Show Details)Tue, Jan 19, 1:12 PM
Addshore updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)Tue, Jan 19, 1:14 PM
Addshore moved this task from Incoming to backlog on the wdwb-tech-focus board.Fri, Jan 22, 10:35 PM
Addshore edited projects, added wdwb-tech-focus (backlog); removed wdwb-tech-focus.
Addshore moved this task from Incoming to Active on the wdwb-tech-focus (backlog) board.
Addshore triaged this task as Medium priority.Fri, Jan 22, 10:37 PM