Maniphest T269141

Allow buttons to take iconOnly prop
Closed, ResolvedPublic
Actions

Assigned To

guergana.tzatchkova

Authored By

	Michael
	Dec 1 2020, 2:40 PM

Tags

Referenced Files

None

Subscribers

guergana.tzatchkova

Description

Buttons can take an iconOnly prop that:

adjusts the outer padding of the button (the spacing between the icon and the border) based on the icon-only button tokens

Notes:

The iconOnly prop does not visually hide the button label, that is up to the application

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Michael	T268982 (MS 2) remove a query block/condition
		Resolved		Lydia_Pintscher	T268658 Create Quiet icon-only button component
		Resolved		guergana.tzatchkova	T269141 Allow buttons to take iconOnly prop

Event Timeline

Michael created this task.Dec 1 2020, 2:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2020, 2:40 PM

Michael moved this task from Incoming to Ready to pick up on the Wikidata Query Builder board.Dec 1 2020, 2:42 PM

Michael moved this task from Ready to pick up to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board.Dec 14 2020, 3:52 PM

Michael edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder.

guergana.tzatchkova moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.Dec 14 2020, 5:03 PM

guergana.tzatchkova updated the task description. (Show Details)Dec 14 2020, 5:20 PM

guergana.tzatchkova updated the task description. (Show Details)Dec 14 2020, 5:50 PM

guergana.tzatchkova updated the task description. (Show Details)Dec 14 2020, 6:25 PM

Sarai-WMDE updated the task description. (Show Details)Dec 14 2020, 6:29 PM

https://github.com/wmde/wikit/pull/328/

guergana.tzatchkova updated the task description. (Show Details)Dec 15 2020, 12:39 PM

guergana.tzatchkova updated the task description. (Show Details)Dec 15 2020, 12:44 PM

guergana.tzatchkova updated the task description. (Show Details)Dec 15 2020, 12:56 PM

guergana.tzatchkova updated the task description. (Show Details)

guergana.tzatchkova updated the task description. (Show Details)Dec 15 2020, 12:58 PM

guergana.tzatchkova claimed this task.Dec 16 2020, 10:13 AM

Sarai-WMDE renamed this task from Add slot and prop for icons to Button component to Allow buttons to take iconOnly prop.Dec 16 2020, 4:41 PM

Sarai-WMDE updated the task description. (Show Details)

guergana.tzatchkova updated the task description. (Show Details)Dec 17 2020, 11:54 AM

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.Dec 17 2020, 4:24 PM

Michael moved this task from Peer Review to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.Dec 18 2020, 2:50 PM

Lydia_Pintscher closed this task as Resolved.Dec 19 2020, 2:26 PM