Conversion table pages are inaccessible for some language variants
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.18

message

The supplied ParserOptions are not safe to cache. Use NO_CACHE.

Impact

Conversion table pages are inaccessible for some language variants

Notes

The new ParserOutputAccess class will complain if asked to produce non-cacheable ParserOutput unless the NO_CACHE flag is given. This behavior was taken from the old code in WikiPage::getParserOutput(). It is now also being applied when coming from Article::view(), which seems to fail in the case of the conversion tables.

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/631264

Details

Request ID: 04b986ed-0db8-4796-a814-dd3d55c4518d
Request URL: https://gan.wikipedia.org/wiki/MediaWiki:Conversiontable/gan-hant

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.18/includes/page/ParserOutputAccess.php(184): MediaWiki\Page\ParserOutputAccess->checkPreconditions(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#1 /srv/mediawiki/php-1.36.0-wmf.18/includes/page/Article.php(732): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#2 /srv/mediawiki/php-1.36.0-wmf.18/includes/actions/ViewAction.php(74): Article->view()
#3 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(532): ViewAction->show()
#4 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(316): MediaWiki->performAction(Article, Title)
#5 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(945): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.36.0-wmf.18/includes/MediaWiki.php(548): MediaWiki->main()
#7 /srv/mediawiki/php-1.36.0-wmf.18/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.36.0-wmf.18/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Project	Branch	Lines +/-	Subject
mediawiki/core	master	+1 -1	Don't cache output that is not safe to cache
mediawiki/core	wmf/1.36.0-wmf.20	+1 -1	Don't cache output that is not safe to cache
mediawiki/core	master	+132 -78	Make ParserCache respect ParserOptions::isSafeToCache

Customize query in gerrit

Related Objects

Mentioned In: T269685: /page/html endpoint broken when requesting language variants affecting /page/summary
T269651: InvalidArgumentException on zhwiki MediaWiki:Conversiontable/zh-hk - "The supplied ParserOptions are not safe to cache. Use NO_CACHE."

Event Timeline

daniel created this task.Dec 1 2020, 6:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2020, 6:20 PM

daniel triaged this task as High priority.Dec 1 2020, 6:20 PM

Change 644605 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Don't cache output that i9s not safe to cache

https://gerrit.wikimedia.org/r/644605

gerritbot added a project: Patch-For-Review.Dec 1 2020, 7:51 PM

The full solution:

Move the ParserOptions::isSafeToCache check into ParserCache::save and in case it's not safe, increment a metric and log a debug log.

Addon1:

Make ParserOptions::isSafeToCache receive userOptions so that we don't skip the cache in case the non-cache-key non-canonical option is not even used

Addon2:

Make ParserOptions::isSafeToCache private and call it from ParserOptions::optionsHash, return null if non-cacheable. Needs preparing the extensions to receiving the null.

CCicalese_WMF added a project: Platform Team Workboards (Clinic Duty Team).Dec 1 2020, 9:11 PM

CCicalese_WMF removed a subscriber: Platform Team Workboards (Clinic Duty Team).

• Clarakosi moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Dec 1 2020, 9:33 PM

Change 644629 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make ParserCache respect ParserOptions::isSafeToCache

https://gerrit.wikimedia.org/r/644629

Change 644665 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@wmf/1.36.0-wmf.20] Don't cache output that is not safe to cache

https://gerrit.wikimedia.org/r/644665

thcipriani moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Dec 2 2020, 7:52 PM

Change 644629 merged by jenkins-bot:
[mediawiki/core@master] Make ParserCache respect ParserOptions::isSafeToCache

https://gerrit.wikimedia.org/r/644629

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 9:01 PM

Reedy merged a task: T269199: "InvalidArgumentException" in Language Conversion Table: The supplied ParserOptions are not safe to cache. Use NO_CACHE..Dec 3 2020, 2:19 AM

Reedy merged a task: T170512: InvalidArgumentException from line 1060 of WikiPage.php: "The supplied ParserOptions are not safe to ...".

Reedy merged a task: T171813: Error occured when viewing difference on conversiontable page.

Reedy added subscribers: Waihorace, Kitabc12345.

Reedy added subscribers: mwjames, Pcj, Samwilson.

Reedy added subscribers: Antigng, SunAfterRain, Liuxinyu970226, Stang.

• Pchelolo mentioned this in T269651: InvalidArgumentException on zhwiki MediaWiki:Conversiontable/zh-hk - "The supplied ParserOptions are not safe to cache. Use NO_CACHE.".Dec 8 2020, 1:09 PM