Page MenuHomePhabricator

Disallow direct "BEGIN"/"COMMIT"/"ROLLBACK" via Database::query()
Open, LowestPublic


For sanity, this would help assure that all of the transaction/session tracking fields of Database do not fall out of sync.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Clarakosi added a subscriber: Clarakosi.

@aaron Do you need implementation support on this?

Note that sql.php should still work.

aaron triaged this task as Lowest priority.Jan 7 2022, 1:11 AM

Change 854953 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: improve Database::queryMulti() error handling

@aaron: Per emails from Sep18 and Oct20 and , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!