Page MenuHomePhabricator
Create Task
Maniphest T269173

Migrate default of $wgMinervaEnableSiteNotice to true
Closed, ResolvedPublic
Actions

Description

The mobile skin MinervaNeue supports site-notices only, if the config MinervaEnableSiteNotice is enabled. This should be the case, as most wikis do not have excessive use of site notices either, as well as doesn't have massive notices that do not fit on mobile devices.

Making this the default is also required to make the entrance for site-notice based extensions (like MediaWiki-extensions-CookieWarning) easier for third-party users.

To achieve that the following things need to be done:

Details

SubjectRepoBranchLines +/-
Move disabling sitenotice on wikimedia wikis to mediawiki-configoperations/mediawiki-configmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Dec 1 2020, 10:12 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 1 2020, 10:12 PM
gerritbot added a comment.Dec 1 2020, 10:17 PM

Change 644627 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florian):
[operations/mediawiki-config@master] Move disabling sitenotice on wikimedia wikis to mediawiki-config

https://gerrit.wikimedia.org/r/644627

gerritbot added a project: Patch-For-Review.Dec 1 2020, 10:17 PM
Florian updated the task description. (Show Details)Dec 1 2020, 10:17 PM
gerritbot added a comment.Dec 1 2020, 10:20 PM

Change 644628 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florian):
[mediawiki/skins/MinervaNeue@master] Change default of showing sitenotices to true

https://gerrit.wikimedia.org/r/644628

Florian updated the task description. (Show Details)Dec 1 2020, 10:20 PM
Jdlrobson awarded a token.Dec 1 2020, 10:40 PM
Jdlrobson closed this task as Resolved.Dec 2 2020, 10:24 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.

Thanks @Florian for taking care of that one!

gerritbot added a comment.Dec 2 2020, 11:03 PM

Change 644627 abandoned by Florianschmidtwelzow:
[operations/mediawiki-config@master] Move disabling sitenotice on wikimedia wikis to mediawiki-config

Reason:
Not needed :)

https://gerrit.wikimedia.org/r/644627

Florian added a comment.Dec 2 2020, 11:03 PM
In T269173#6665104, @Jdlrobson wrote:

Thanks @Florian for taking care of that one!

Thanks for the fast review! :)

Anoop mentioned this in T347814: Enable wgMinervaEnableSiteNotice for newiki.Oct 2 2023, 10:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL