New Discussion Tool pre-fomats signature
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Dec 2 2020, 12:49 AM

Description

This task is about removing the styling the New Discussion Tool appears to be adding to signatures in topics that contain bulleted lists.

Behavior

Visit the latest version of the New Discussion Tool prototype: https://patchdemo.wmflabs.org/wikis/f6c284e009aa861712491b41d84fe464/w/index.php/Talk:Main_Page
Open the New Discussion Tool by tapping the "Add topic" button
Enter some text in the Topic field
Create a bulleted list
Click Add topic button to publish the topic you drafted in Steps 2. and 3.

Actual

❗️Notice the signature that accompanies the comment you posted in "Step 5." is styled differently from the rest of the topic contents and page:

Expected

✅ Notice the signature that accompanies the comment you posted in "Step 5." is styled similarly to the content on the rest of the page:

Note: I've manually highlighted the text in the screenshot above.

Done

"Expected" behavior is implemented

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/DiscussionTools	master	+10 -5	Trim signatures when added on a new line

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T233446 [Epic] New Discussion Tool
Open	None	T259561 New Discussion Tool V1.0: Engineering
Resolved	matmarex	T267595 Build New Discussion Tool v1.0 prototype
Resolved	• ppelberg	T269188 New Discussion Tool pre-fomats signature

Event Timeline

• ppelberg created this task.Dec 2 2020, 12:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2020, 12:49 AM

• ppelberg added a project: Editing-team (FY2021-22 Kanban Board).Dec 2 2020, 12:50 AM

• ppelberg moved this task from Incoming to Upcoming on the Editing-team (FY2021-22 Kanban Board) board.

• ppelberg removed a subscriber: Editing-team (FY2021-22 Kanban Board).

• ppelberg added a parent task: T259561: New Discussion Tool V1.0: Engineering.Dec 2 2020, 12:57 AM

• ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (FY2021-22 Kanban Board) board.Dec 2 2020, 1:16 AM

• ppelberg edited parent tasks, added: T267595: Build New Discussion Tool v1.0 prototype; removed: T259561: New Discussion Tool V1.0: Engineering.

The cause is the space inserted before the signature when it's on its own line.

This is only not an issue in reply mode because the indentation syntax prevents the space from have any meaning. : is the same as : .

This is also only a problem in visual mode. In source mode we trim source whitespace, so the signature ends up on the same line as the last bullet point.

Change 644904 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Trim signatures when added on a new line

https://gerrit.wikimedia.org/r/644904

gerritbot added a project: Patch-For-Review.Dec 2 2020, 7:34 PM

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.Dec 2 2020, 7:48 PM

Looks like we saw this coming:

// TODO: When we implement posting new topics, the leading space will create an indent-pre

Change 644904 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Trim signatures when added on a new line

https://gerrit.wikimedia.org/r/644904

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 10:00 PM

Esanders renamed this task from New Discussion Tool wraps adds unwanted styling to signature to New Discussion Tool pre-fomats signature.Dec 2 2020, 10:05 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 10:10 PM

New demo wiki: https://patchdemo.wmflabs.org/wikis/6307a9de3d522c12e7daaa1bb7904435/w/index.php/Talk:Main_Page

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.Dec 2 2020, 11:02 PM