Warn people before they discard a new topic
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Dec 2 2020, 1:01 AM

Description

This task is about showing people a warning dialog before closing/discarding the Topic they've drafted.

Behavior

Visit: https://patchdemo.wmflabs.org/wikis/f6c284e009aa861712491b41d84fe464/w/index.php/Talk:Main_Page
Open the New Discussion Tool by clicking the Add topic button
Enter some text into the Topic field; do NOT enter any text into the Description field
Press ⎋ or click the red Cancel button/link within the tool

Actual

❗️Notice the New Discussion Tool closes, and the topic you started drafted in "Step 3." is lost, without warning

Expected

✅Notice the following warning appears: Are you sure? Are you sure you want to discard the topic you are writing?

Done

"Expected" behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Separate dialog for abandoning a new topic	mediawiki/extensions/DiscussionTools	master	+57 -27

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T233446 [Epic] New Discussion Tool
Open	None	T259561 New Discussion Tool V1.0: Engineering
Resolved	matmarex	T267595 Build New Discussion Tool v1.0 prototype
Resolved	matmarex	T269190 Warn people before they discard a new topic

Event Timeline

• ppelberg created this task.Dec 2 2020, 1:01 AM

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.

• ppelberg edited parent tasks, added: T267595: Build New Discussion Tool v1.0 prototype; removed: T259561: New Discussion Tool V1.0: Engineering.Dec 2 2020, 1:17 AM

Done in patchset 15 of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/623117 (it's easier for me to keep these in one change)

New demo wiki: https://patchdemo.wmflabs.org/wikis/6307a9de3d522c12e7daaa1bb7904435/w/index.php/Talk:Main_Page

(Also, fixed the topic field so that Enter and Escape keys work in it as expected)

• ppelberg updated the task description. (Show Details)Dec 2 2020, 11:03 PM

In T269190#6665237, @matmarex wrote:

Done in patchset 15 of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/623117 (it's easier for me to keep these in one change)

New demo wiki: https://patchdemo.wmflabs.org/wikis/6307a9de3d522c12e7daaa1bb7904435/w/index.php/Talk:Main_Page

This seems to be working for me:

Screen Shot 2020-12-03 at 9.03.17 AM.png (1×2 px, 281 KB)

Note: the dialog copy needs to be changed. This work will happen in: T264220.

(Also, fixed the topic field so that Enter and Escape keys work in it as expected)

@matmarex: can you share more details about what you consider to be "expected" in this context?

In T269190#6667258, @ppelberg wrote:

(Also, fixed the topic field so that Enter and Escape keys work in it as expected)

@matmarex: can you share more details about what you consider to be "expected" in this context?

Enter attempts to submit the message, and Escape attempts to discard the message. This is the same as the behavior of the comment summary field.

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Dec 12 2020, 3:34 AM

(patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/623117 was merged)

The copy in the dialog message does not seem to be showing as expected:

Actual

❗️ Are you sure you want to discard the comment you are writing?

Expected

✅Are you sure? Are you sure you want to discard the topic you are writing?

Oops, I think I missed that at first, and then you said (T269190#6667258) that this will be done in a separate task. But it's probably better to do it now.

Change 656959 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Separate dialog for abandoning a new topic

https://gerrit.wikimedia.org/r/656959

gerritbot added a project: Patch-For-Review.Jan 18 2021, 6:19 PM

matmarex claimed this task.Jan 18 2021, 6:19 PM

matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.

Test wiki created on Patch Demo by Iamjessklein using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/0985eaeb6d89e322a14e1fadcde1646d/w/

Change 656959 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Separate dialog for abandoning a new topic

https://gerrit.wikimedia.org/r/656959

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 12:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 1:00 AM

In T269190#6756122, @matmarex wrote:

Oops, I think I missed that at first, and then you said (T269190#6667258) that this will be done in a separate task.

You're right. I'm sorry for that confusion.

Either way, the copy looks good. [i]

i. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats