Page MenuHomePhabricator
Create Task
Maniphest T269231

Localized precision in time inputs
Closed, ResolvedPublic
Actions

Description

(see screenshot in parent task)
The currently shown label of the time precision is hardcoded in DataValuesJavaScript via https://gerrit.wikimedia.org/g/data-values/value-view/+/d1456b6f967248cfdc2c93b7d7f317f2823bbf27/src/experts/TimeInput.js#17

BDD
GIVEN an input field for dates
WHEN entering a value
THEN the precision is shown in the UI language

Details

SubjectRepoBranchLines +/-
Update data-values/value-view submodulemediawiki/extensions/Wikibasemaster+1 -1
Add and use value-view time precision messagesmediawiki/extensions/Wikibasemaster+16 -1
Fix stray colon in message keydata-values/value-viewmaster+2 -2
Translate time precisiondata-values/value-viewmaster+38 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

noarave created this task.Dec 2 2020, 1:54 PM
noarave updated the task description. (Show Details)Dec 2 2020, 1:59 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 2 2020, 2:15 PM
ItamarWMDE claimed this task.Dec 4 2020, 4:41 PM
ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ItamarWMDE removed ItamarWMDE as the assignee of this task.Dec 4 2020, 4:54 PM
ItamarWMDE moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ItamarWMDE subscribed.
Lucas_Werkmeister_WMDE claimed this task.Dec 15 2020, 1:51 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Dec 17 2020, 1:36 PM

Change 650116 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[data-values/value-view@master] Translate time precision

https://gerrit.wikimedia.org/r/650116

gerritbot added a project: Patch-For-Review.Dec 17 2020, 1:36 PM

Change 650117 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add and use value-view time precision messages

https://gerrit.wikimedia.org/r/650117

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 17 2020, 1:39 PM
gerritbot added a comment.Dec 18 2020, 1:23 PM

Change 650116 merged by jenkins-bot:
[data-values/value-view@master] Translate time precision

https://gerrit.wikimedia.org/r/650116

gerritbot added a comment.Dec 18 2020, 2:24 PM

Change 650506 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[data-values/value-view@master] Fix stray colon in message key

https://gerrit.wikimedia.org/r/650506

gerritbot added a comment.Dec 18 2020, 2:41 PM

Change 650506 merged by jenkins-bot:
[data-values/value-view@master] Fix stray colon in message key

https://gerrit.wikimedia.org/r/650506

hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 31 2020, 5:31 PM
gerritbot added a comment.Dec 31 2020, 5:57 PM

Change 650117 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add and use value-view time precision messages

https://gerrit.wikimedia.org/r/650117

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 31 2020, 6:00 PM
Lydia_Pintscher added a comment.Jan 8 2021, 2:36 PM

My understanding is that this should now be available on production. If I set my UI to German the precision is still shown in English. Is this a matter of translations not being done yet?

Lydia_Pintscher added a comment.Jan 8 2021, 2:36 PM

Similar to T269232#6691881 ?

gerritbot added a comment.Jan 11 2021, 2:55 PM

Change 655432 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/655432

Lucas_Werkmeister_WMDE added a comment.Jan 11 2021, 2:59 PM
In T269231#6731737, @Lydia_Pintscher wrote:

Similar to T269232#6691881 ?

Probably, yes. There should be some coordinate precision translations deployed by now, but no time precision translations yet. The above change should fix that – I hope it’ll make it into this week’s train.

gerritbot added a comment.Jan 11 2021, 5:06 PM

Change 655432 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/655432

Lucas_Werkmeister_WMDE added a comment.Jan 14 2021, 5:04 PM

Translations should be deployed now.

Lydia_Pintscher closed this task as Resolved.Jan 15 2021, 10:12 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL