Localized precision in geocoordinate inputs
Closed, ResolvedPublic
Actions

Description

(see screenshot in parent task)

BDD
GIVEN an input field for geocoordinates
WHEN entering a value
THEN the precision is shown in the UI language

the currently shown label for the coordinate precision is hardcoded here: https://gerrit.wikimedia.org/g/data-values/value-view/+/d1456b6f967248cfdc2c93b7d7f317f2823bbf27/src/experts/GlobeCoordinateInput.js#37
interestingly WikibaseMediaInfo seems to be doing a good job there already https://gerrit.wikimedia.org/g/mediawiki/extensions/WikibaseMediaInfo/+/705a2a550d48f5e25c1e259292705313604cafaa/resources/statements/inputs/GlobeCoordinateInputWidget.js#462

Details

Subject	Repo	Branch	Lines +/-
Update data-values/value-view submodule	mediawiki/extensions/Wikibase	master	+1 -1
Add and use value-view precision messages	mediawiki/extensions/Wikibase	master	+7 -1
Translate globe coordinate precision	data-values/value-view	master	+21 -9
Change GlobeCoordinateInput helper functions to methods	data-values/value-view	master	+81 -74

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T78430 [Epic] Getting Wikidata to render nicely on mobile web
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Open	None	T95878 [Story] Make Wikidata editable on mobile web
Open	None	T95649 Create and document a stable framework for extending the Wikibase UI
Stalled	None	T40968 Keyboard-navigability of the repo UI
Open	None	T54136 [Epic] Redesign Item UI for Wikidata repo
Open	None	T103834 [Epic] Improve input elements for complex datatypes
Open	None	T170273 Meta-bug: Wikidata Usability Testing 2017-7
Resolved	Lydia_Pintscher	T170424 In Wikidata value entering boxes "Malformed value", date precision values, and other elements cannot be translated
Resolved	Lydia_Pintscher	T269102 Localized precision in time and geocoordinate inputs
Resolved	Lucas_Werkmeister_WMDE	T269232 Localized precision in geocoordinate inputs

Event Timeline

noarave created this task.Dec 2 2020, 1:58 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 2 2020, 2:15 PM

Lucas_Werkmeister_WMDE claimed this task.Dec 4 2020, 12:03 PM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 645335 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[data-values/value-view@master] Change GlobeCoordinateInput helper functions to methods

https://gerrit.wikimedia.org/r/645335

Change 645336 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[data-values/value-view@master] Translate globe coordinate precision

https://gerrit.wikimedia.org/r/645336

Change 645337 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add and use value-view precision messages

https://gerrit.wikimedia.org/r/645337

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 4 2020, 12:39 PM

@Lydia_Pintscher the hard-coded precisions have one value that doesn’t look like the others:

to an arcminute
to an arcsecond
to 1/10 of an arcsecond
to 1/100 of an arcsecond
to 1/1000 of an arcsecond
1/10000'

Should we make that last one translatable as well? Apparently it was added (in DataValues #99) because it can be auto-detected by the backend, but it’s not usually offered as a choice in the dropdown list. (The pull request description doesn’t say what input would make the backend detect that precision, and I haven’t found one yet, which makes this a bit more difficult to reason about.)

Change 645335 merged by jenkins-bot:
[data-values/value-view@master] Change GlobeCoordinateInput helper functions to methods

https://gerrit.wikimedia.org/r/645335

Change 645336 merged by jenkins-bot:
[data-values/value-view@master] Translate globe coordinate precision

https://gerrit.wikimedia.org/r/645336

Change 645337 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add and use value-view precision messages

https://gerrit.wikimedia.org/r/645337

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 4 2020, 5:40 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 4 2020, 6:00 PM

In T269232#6669181, @Lucas_Werkmeister_WMDE wrote:

@Lydia_Pintscher the hard-coded precisions have one value that doesn’t look like the others:

to an arcminute

to an arcsecond

to 1/10 of an arcsecond

to 1/100 of an arcsecond

to 1/1000 of an arcsecond

1/10000'

Should we make that last one translatable as well? Apparently it was added (in DataValues #99) because it can be auto-detected by the backend, but it’s not usually offered as a choice in the dropdown list. (The pull request description doesn’t say what input would make the backend detect that precision, and I haven’t found one yet, which makes this a bit more difficult to reason about.)

@thiemowmde can you help shed some light on the above?

1/10000'

Should we make that […] translatable as well?

Yes, I suggest to make it translatable. One might want to localize this as "1/10000 of a second", or something like "1/10.000 Sekunde" in German.

It appears like the Geo library was heavily changed in 2019. I can't tell how much the precision detection changed as well when this happened. I found a bit of code that limits seconds to at most 4 decimal places, i.e. 0.0001 or 1/10,000.

Thanks :) Let's do that then.

This is deployed on Wikidata now, but the version that’s deployed has no translations yet, so it effectively makes no difference. There are some translations on translatewiki.net and in the source code repository by now, but we need to update the Git submodule in Wikibase to pull them in. Since there won’t be a deployment train for the next few weeks (and we unfortunately missed this week’s train), I think we can do that submodule update a bit later (first days of January), to leave some more time for translations to come in.

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 16 2020, 10:23 AM

Lydia_Pintscher mentioned this in T269231: Localized precision in time inputs.Jan 8 2021, 2:36 PM

Change 655432 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/655432

Change 655432 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update data-values/value-view submodule

https://gerrit.wikimedia.org/r/655432

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.26; 2021-01-12); removed MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Jan 11 2021, 6:00 PM

Lucas_Werkmeister_WMDE moved this task from Stalled/Waiting to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 14 2021, 5:02 PM