Page MenuHomePhabricator
Create Task
Maniphest T269262

Integrate the DOM library with RemexHtml
Closed, ResolvedPublic
Actions

Description

Domino.js comes with both a tree builder as well as a DOM library. RemexHtml covers the tree builder piece and is in use in various Wikimedia codebases. It currently integrates with the PHP-DOM-libxml combo which we would need to replace with the new DOM library.

So, this task is to figure out the details involved in the integration with RemexHtml, write the code for it, and test it. This may necessitate adding configuration options in RemexHtml if it doesn't already exist to pick a DOM library (see T271728: Migration strategy from DOMDocument to Dodo).

Details

SubjectRepoBranchLines +/-
Allow use of third-party DOM implementationsmediawiki/libs/RemexHtmlmaster+54 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry renamed this task from Integrate the DOM library with Remex to Integrate the DOM library with RemexHtml.Dec 2 2020, 5:11 PM
ssastry created this task.
ssastry triaged this task as Medium priority.Dec 2 2020, 5:58 PM
cscott mentioned this in T269259: Set up test infrastructure for testing the library against standard spec test suites.Jan 11 2021, 3:54 PM
cscott mentioned this in T269254: Complete porting of Dodo (PHP port of Domino node.js DOM library).Jan 11 2021, 4:20 PM
cscott updated the task description. (Show Details)Jan 11 2021, 4:40 PM
ssastry edited projects, added Parsoid (Dodo); removed Parsoid.Jan 14 2021, 7:26 PM
cscott subscribed.Feb 1 2021, 8:18 PM

Basically there's one "builder" class in remex html; dodo could implement that to quickly get a tree builder. Alternatively, we could remove some explicit type casts (as I did for zest) to get a "universal" remex that would work with any some library as long as it was given an appropriate duck typed "DOMImplementation" class.

gerritbot added a comment.Feb 1 2021, 10:43 PM

Change 660954 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/libs/RemexHtml@master] Allow use of third-party DOM implementations

https://gerrit.wikimedia.org/r/660954

gerritbot added a project: Patch-For-Review.Feb 1 2021, 10:43 PM
gerritbot added a comment.Feb 5 2021, 8:40 PM

Change 660954 merged by jenkins-bot:
[mediawiki/libs/RemexHtml@master] Allow use of third-party DOM implementations

https://gerrit.wikimedia.org/r/660954

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2021, 9:10 PM
cscott added a comment.Jun 11 2021, 9:15 PM

Still to-do:

  • implement getters and setters for innerHTML and outerHTML using Remex.
  • implement DOM Parsing & serialization interfaces from IDLeDOM 0.5.0
  • implement PHP-specific Document::{load,loadXML,saveHTML,saveXML} methods (also defined in IDLeDOM 0.5.0)
ssastry closed this task as Resolved.Sep 1 2021, 1:26 AM
ssastry assigned this task to cscott.

The above are done now. Resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL