FilterLookup.php on line 346
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Dec 3 2020, 1:21 AM

Description

Error

MediaWiki version: 1.36.0-wmf.20

message

Argument 5 passed to MediaWiki\Extension\AbuseFilter\Filter\Specs::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php on line 346

Impact

Notes

Details

Request ID: X8g3GApAMNUAA5Bv260AAADL
Request URL: https://commons.wikimedia.org/wiki/Special:AbuseFilter/history/28/item/127

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php(346): MediaWiki\Extension\AbuseFilter\Filter\Specs->__construct(string, string, string, array, NULL)
#1 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php(329): MediaWiki\Extension\AbuseFilter\FilterLookup->filterFromRow(stdClass, array)
#2 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php(266): MediaWiki\Extension\AbuseFilter\FilterLookup->getFilterFromHistory(stdClass)
#3 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/Views/AbuseFilterViewEdit.php(1121): MediaWiki\Extension\AbuseFilter\FilterLookup->getFilterVersion(integer)
#4 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/Views/AbuseFilterViewEdit.php(100): AbuseFilterViewEdit->loadFromDatabase(integer, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/special/SpecialAbuseFilter.php(63): AbuseFilterViewEdit->show()
#6 /srv/mediawiki/php-1.36.0-wmf.20/includes/specialpage/SpecialPage.php(645): SpecialAbuseFilter->execute(string)
#7 /srv/mediawiki/php-1.36.0-wmf.20/includes/specialpage/SpecialPageFactory.php(1402): SpecialPage->run(string)
#8 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(945): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(548): MediaWiki->main()
#11 /srv/mediawiki/php-1.36.0-wmf.20/index.php(53): MediaWiki->run()
#12 /srv/mediawiki/php-1.36.0-wmf.20/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

	Subject	Repo	Branch	Lines +/-
	Use 'default' as default group when reading filters from history	mediawiki/extensions/AbuseFilter	wmf/1.36.0-wmf.20	+5 -0
	Use 'default' as default group when reading filters from history	mediawiki/extensions/AbuseFilter	master	+5 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T263186 1.36.0-wmf.20 deployment blockers
		Resolved	PRODUCTION ERROR	Daimona	T269314 Argument 5 passed to MediaWiki\Extension\AbuseFilter\Filter\Specs::__construct() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php on line 346

Event Timeline

Reedy created this task.Dec 3 2020, 1:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2020, 1:21 AM

Reedy mentioned this in T269286: Monolog update removes exception object from logstash.Dec 3 2020, 1:22 AM

Oh, apparently rEABFdc207d0cbd75a35a77e03410388b5b05d78fceb8 added a default of 'default' for abuse_filter.af_group, but not for abuse_filter_history.afh_group, so rows created before that commit have a null field.

Quick solution: add normalization to FilterLookup::getFilterFromHistory
Long-term solution: add a default to that field. It will make old filters appear as if they were created in the 'default' group, but I don't think it's a problem

@Daimona Do we know if the specific Fatal TypeError seen here is newly caused? Should we halt rollout to group2?

Krinkle added a parent task: T263186: 1.36.0-wmf.20 deployment blockers.Dec 3 2020, 3:18 AM

Krinkle moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.

Krinkle moved this task from Nov 2020 to Untriaged on the Wikimedia-production-error board.

Krinkle moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.Dec 3 2020, 3:20 AM

Change 644966 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Cast $row->af_group to string when creating Specs

https://gerrit.wikimedia.org/r/644966

gerritbot added a project: Patch-For-Review.Dec 3 2020, 5:09 AM

In T269314#6665653, @Krinkle wrote:

@Daimona Do we know if the specific Fatal TypeError seen here is newly caused? Should we halt rollout to group2?

Hm, yes, it was included in .19, which was deployed together with .20. It prevents viewing old versions of filters, created before 2012. Not serious enough to revert, but serious enough to backport a fix before moving on.

Agusbou2015 added a subscriber: Agusbou2015.Dec 3 2020, 1:26 PM

https://gerrit.wikimedia.org/r/644966 proposes a fix though it is not ready yet. Is there a change we can easily revert to unblock the train or should we hold on the fix to be completed?

In T269314#6666812, @hashar wrote:

Is there a change we can easily revert to unblock the train or should we hold on the fix to be completed?

The revert would be painful. Let me update the fix

Daimona mentioned this in T263324: Make some DB columns more consistent.Dec 3 2020, 2:51 PM

Change 644966 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use 'default' as default group when reading filters from history

https://gerrit.wikimedia.org/r/644966

Change 644984 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.20] Use 'default' as default group when reading filters from history

https://gerrit.wikimedia.org/r/644984

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 3 2020, 7:00 PM

Change 644984 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.36.0-wmf.20] Use 'default' as default group when reading filters from history

https://gerrit.wikimedia.org/r/644984

Validated on mwdebug1001 using https://commons.wikimedia.org/wiki/Special:AbuseFilter/history/28/item/127 as the example.

Mentioned in SAL (#wikimedia-operations) [2020-12-03T19:57:06Z] <hashar@deploy1001> Synchronized php-1.36.0-wmf.20/extensions/AbuseFilter/includes/FilterLookup.php: Use 'default' as default group when reading filters from history - T269314 (duration: 01m 05s)