Page MenuHomePhabricator

#forminput - Input field collabses when not enough space
Open, Needs TriagePublic

Description

Since 5.0 the input field of forminput-parserfunction shrinks to a minimum when there is not enough space around f.exmpl. within an table. This makes it unuseable in some cases.

In former versions there was a break between the input flield and the send-button, so the button could float to the next line. The input field had the fixed length given in size=.

Ralf H.

Version

MW 1.31.1
SMW 3.2.1
SCQ 2.1.0
SRF 3.2.0
PF 5.0
Maps 7.20.1
SemanticDrilldown 2.1

Event Timeline

Why do you have #forminput in a table?

For styling puposes. I like to have some explanation beside the forminput, because not everybody seem to understand how to use it (Mostly because people just click the button without entering something to the input flield).

I mean this "shrinking" is somehow oposit to the size= option.

#forminput now uses OOUI, and by default OOUI places the button right near the input. I'm sure that there's a way to add a new parameter to #forminput like "separate button", and have that display the input and button separately so that they can be on separate lines. But would this be an improvement to the display? If you want help text for the form input, can't you just put it above (or below) the input, rather than to its side?

I'd prefer the former design - the space around depends on the size of the input field. At this moment parameter size is pretty useless and the current behaviour makes #forminput unuseable in many existing cases. Example:

FormInput_compressed.png (277×404 px, 7 KB)
Wich one to chose?

I understand that you'd prefer having the button on a separate line, but can you live with the current approach? Could you just expand the width of that table cell/column?

from reading above I understand that i have to set input field a fixed size..?? am i right if yes how to approach this project i am new to this project and starting fixing this..
Please Guide

I understand that you'd prefer having the button on a separate line, but can you live with the current approach? Could you just expand the width of that table cell/column?

Yes I can. But in my opinion size= should affect the size of the input field regardless if there is enough space around.