Page MenuHomePhabricator

Add Link engineering: Refactor task handling backend to make adding new task types easier
Closed, ResolvedPublic

Description

Introduce a task type registry and collect all tasktype-specific code in it.

Unlike most other Add Link engineering changes, this affects lots of existing code and has a high risk of breaking current functionality so it needs to be tested thoroughly, including on sites which use local search. The affected functionality is the homepage suggested edits module + suggested edits content in the help panel + change tags.

Event Timeline

Change 644771 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Remove tracking of individual templates from suggested edits

https://gerrit.wikimedia.org/r/644771

Change 644461 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Introduce TaskTypeHandlerRegistry

https://gerrit.wikimedia.org/r/644461

Change 645221 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Make Task, TaskType and Topic JsonUnserializable

https://gerrit.wikimedia.org/r/645221

Change 645231 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Track task type alongside with target page ID

https://gerrit.wikimedia.org/r/645231

Change 645297 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] [WIP] Add LinkRecommendation task type

https://gerrit.wikimedia.org/r/645297

Change 645481 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] [DNM] Remove cache migration logic

https://gerrit.wikimedia.org/r/645481

Change 644771 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove tracking of individual templates from suggested edits

https://gerrit.wikimedia.org/r/644771

Change 644461 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Introduce TaskTypeHandlerRegistry

https://gerrit.wikimedia.org/r/644461

Change 645221 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make Task, TaskType and Topic JsonUnserializable

https://gerrit.wikimedia.org/r/645221

Change 651305 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Track task type alongside with target page ID, step 1

https://gerrit.wikimedia.org/r/651305

Change 651305 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Track task type alongside with target page ID, step 1

https://gerrit.wikimedia.org/r/651305

Change 645231 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Track task type alongside with target page ID, step 2

https://gerrit.wikimedia.org/r/645231

Change 645297 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add LinkRecommendation task type

https://gerrit.wikimedia.org/r/645297

Change 645481 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove cache migration logic

https://gerrit.wikimedia.org/r/645481

@Etonkovidova do you want to do more QA or shall we resolve this? I think the QA is basically to check the full workflow of suggested edits (difficulty filters, guidance content, change tags after edit). The code has been in production for a few trains now.

@Etonkovidova do you want to do more QA or shall we resolve this? I think the QA is basically to check the full workflow of suggested edits (difficulty filters, guidance content, change tags after edit). The code has been in production for a few trains now.

All QA is done - Closing as Resolved.