Page MenuHomePhabricator
Create Task
Maniphest T269415

Highlighting of translated sentences should not be persistent
Closed, ResolvedPublic
Actions

Description

As part of the "Pick a sentence" step (T251551) users are expected to see only one selected sentence at a time, which can be highlighted in either yellow (if it has not been translated) or blue (if it was translated already).

However, currently as sentences get translated they keep the blue backgorund even when they are not selected:

Screenshot 2020-12-04 at 10.08.37.png (750×500 px, 103 KB)

This ticket focuses on making sure that translated sentences are only highlighted when they are selected. Other adjustments for translated sentences are captured in T260128

Details

SubjectRepoBranchLines +/-
SX Pick a sentence: Fix translated segments highlightingmediawiki/extensions/ContentTranslationmaster+35 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Dec 4 2020, 9:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2020, 9:14 AM
Pginer-WMF triaged this task as Medium priority.Dec 4 2020, 9:14 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2020-October-December) board.
ngkountas claimed this task.Dec 17 2020, 5:43 AM
ngkountas moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-October-December) board.
gerritbot added a comment.Dec 17 2020, 5:48 AM

Change 650020 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix translated segments highlighting

https://gerrit.wikimedia.org/r/650020

gerritbot added a project: Patch-For-Review.Dec 17 2020, 5:48 AM
Pginer-WMF moved this task from Backlog to Desktop editor on the SectionTranslation board.Dec 18 2020, 11:27 AM
Pginer-WMF moved this task from Desktop editor to Mobile editor on the SectionTranslation board.
Pginer-WMF added a project: CX-mobile.Dec 18 2020, 2:48 PM
gerritbot added a comment.Dec 21 2020, 11:09 AM

Change 650020 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix translated segments highlighting

https://gerrit.wikimedia.org/r/650020

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2020, 11:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 21 2020, 12:00 PM
Pginer-WMF edited projects, added Language-Team (Language-2021-January-March); removed Language-Team (Language-2020-October-December).Jan 4 2021, 10:15 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-January-March) board.
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-January-March) board.Jan 12 2021, 12:07 PM
ngkountas moved this task from Needs QA to In Review on the Language-Team (Language-2021-January-March) board.Jan 12 2021, 12:10 PM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-January-March) board.Jan 14 2021, 3:11 PM
• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2021-January-March) board.Jan 15 2021, 9:20 PM
• Jpita subscribed.

sometimes the Skip button doesn't work (can't figure out exactly when)

buttonNotWorking.gif (822×438 px, 2 MB)

when using the buttons to move between sentences, when we go to the title, the first paragraph is also selected instead of just the title
titleAndfirstParag.gif (822×438 px, 1 MB)

Pginer-WMF added a comment.Jan 18 2021, 8:48 AM

These seem aspects that need polishing. Unless this is really quick to fix, we may prefer to capture these in a separate ticket.
@ngkountas can provide more input on that aspect.

ngkountas added a comment.Jan 18 2021, 11:47 AM

First issue fixed in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/656844. Second issue fixed in this one: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/656869. Since we already have solutions for these issues, I do not think separate tickets would be necessary.

ngkountas moved this task from Pending input for QA to In Review on the Language-Team (Language-2021-January-March) board.Jan 18 2021, 11:47 AM
Pginer-WMF added a parent task: T251551: Section Translation Editor: Pick a sentence.Jan 21 2021, 11:13 AM
Pginer-WMF added a comment.Jan 21 2021, 11:26 AM

Maybe it was not mentioned explicitly, but for the translated text we should still use black (Base20) as the text color, even when there is no background highlighted. I created a separate ticket for this: T272583: Translated content should use a darker text color

ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-January-March) board.Jan 27 2021, 1:55 PM
• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2021-January-March) board.Jan 28 2021, 3:33 PM
Pginer-WMF closed this task as Resolved.Feb 1 2021, 10:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL