Page MenuHomePhabricator

Highlighting of translated sentences should not be persistent
Closed, ResolvedPublic

Description

As part of the "Pick a sentence" step (T251551) users are expected to see only one selected sentence at a time, which can be highlighted in either yellow (if it has not been translated) or blue (if it was translated already).

However, currently as sentences get translated they keep the blue backgorund even when they are not selected:

This ticket focuses on making sure that translated sentences are only highlighted when they are selected. Other adjustments for translated sentences are captured in T260128

Event Timeline

Change 650020 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix translated segments highlighting

https://gerrit.wikimedia.org/r/650020

Change 650020 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Pick a sentence: Fix translated segments highlighting

https://gerrit.wikimedia.org/r/650020

Jpita added a subscriber: Jpita.

sometimes the Skip button doesn't work (can't figure out exactly when)


when using the buttons to move between sentences, when we go to the title, the first paragraph is also selected instead of just the title

These seem aspects that need polishing. Unless this is really quick to fix, we may prefer to capture these in a separate ticket.
@ngkountas can provide more input on that aspect.

First issue fixed in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/656844. Second issue fixed in this one: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/656869. Since we already have solutions for these issues, I do not think separate tickets would be necessary.

Maybe it was not mentioned explicitly, but for the translated text we should still use black (Base20) as the text color, even when there is no background highlighted. I created a separate ticket for this: T272583: Translated content should use a darker text color