Page MenuHomePhabricator

Forcibly creating a local account creates an erroneous automatic creation log entry
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

Force create a local account using Special:CreateLocalAccount.

Actual Results:

Two log entries are created, one for forcibly creating a local account and one for automatic creation. (example)

Expected Results:

One log entry is created, for forcibly creating a local account, since creation is not automatic.

Event Timeline

Urbanecm added a subscriber: Urbanecm.

Needs MW's authstack to support the idea of forced account creation.

@Urbanecm Why not just add a parameter to AuthManager::autoCreateUser() called log which is true by default but could be set to false in this specific use case?

@Urbanecm Why not just add a parameter to AuthManager::autoCreateUser() called log which is true by default but could be set to false in this specific use case?

Hmm... because no one had such an idea :-). Can work. Will you try to upload a patch for it?

Yes, you can expect it in a few days.

Great, thanks! Will do my best to review it :).

Change 667408 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/core@master] Control whether a log is created when accounts are autocreated

https://gerrit.wikimedia.org/r/667408

Change 667409 had a related patch set uploaded (by Huji; owner: Huji):
[mediawiki/extensions/CentralAuth@master] Do not create an 'autocreate' log when forcibly creating local accounts

https://gerrit.wikimedia.org/r/667409

Great, thanks! Will do my best to review it :).

The patches should be ready to go now. I rebased them just in case.

Thanks for the kind reminder @Huji. I +2'ed both patches, should be merged shortly.

Change 667408 merged by jenkins-bot:
[mediawiki/core@master] Control whether a log is created when accounts are autocreated

https://gerrit.wikimedia.org/r/667408

Change 667409 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Do not create an 'autocreate' log when forcibly creating local accounts

https://gerrit.wikimedia.org/r/667409

Urbanecm claimed this task.