Page MenuHomePhabricator

[Epic] Make MobileFrontend compatible with Parsoid HTML
Open, MediumPublic

Description

Parsoid-based read views are on the horizon. 2021 will probably start seeing small beginnings and by the end of the year, the Parsing Team expects to have made significant progress towards shifting wikis to use Parsoid HTML for read views.

There will be several milestones along the way. T265943: Decide on EOFY (June 2021) Parsoid read-view target use-case might look at mediawiki.org and/or officewiki as the first guinea pig.

Given this, MobileFrontend should start preparing to consume Parsoid HTML. There will be a transitional period (likely on the order of many months) when both Parsoid and core parser will be serving wikis as we iron out kinks in rendering, performance, features, etc. But, the final switch will likely definitely happen in 2022.

The Parsing Team's hunch is that MobileFrontend code will potentially be simplified with the switch to Parsoid HTML. For example, Parsoid output comes with section tags that are compatible with core parser output and MobileFrontend can simply consume them instead of craft these sections internally.

We are happy to collaborate with other developers to ensure that this transition can happen as smoothly as possible including addressing any missing functionality.

Related Objects

StatusSubtypeAssignedTask
Openovasileva
ResolvedBUG REPORTJdlrobson
ResolvedBUG REPORTovasileva
ResolvedBUG REPORTovasileva
DuplicateNone
ResolvedEdtadros
Resolvedovasileva
ResolvedABreault-WMF
ResolvedSToyofuku-WMF
ResolvedSToyofuku-WMF
ResolvedSToyofuku-WMF
ResolvedPRODUCTION ERRORJdlrobson-WMF
Resolvedovasileva
Resolvedovasileva
ResolvedBUG REPORTJdlrobson
Resolvedovasileva
OpenNone
ResolvedFeatureSToyofuku-WMF

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

@ssastry looks like this ticket got swept out of backlog in a grooming session. It needs prioritizing.

T366391 is scheduled for next sprint - we need to determine what the correct long term solution for this would be. If you have any suggestions of how this might be done in a modern way in Parsoid - please do share your thoughts on ticket to speed things up!

Change #1075635 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on mobile support for Parsoid Read Views (but not on talk pages)

https://gerrit.wikimedia.org/r/1075635

Change #1075635 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on mobile support for Parsoid Read Views (but not on talk pages)

https://gerrit.wikimedia.org/r/1075635

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:20:59Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:23:01Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, cscott: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-10T13:37:09Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1075635|Turn on mobile support for Parsoid Read Views (but not on talk pages) (T269499 T376048)]], [[gerrit:1079274|Turn on Parsoid Selective Update metrics (take 2) (T371713 T376433)]] (duration: 16m 09s)

It seems to work quite well now, but I noticed several differences that don't seem to be noted anywhere. I'll leave it to you to split off sub-tasks and figure out who should own them.

I tested on the these pages:

  1. On article pages, when sections are collapsed, old parser hides the section edit buttons, but Parsoid does not
  2. On article pages, when the section edit buttons are tapped, Parsoid also collapses the section in the background
  3. On talk pages, old parser always collapses all sections, but Parsoid may expand them according to user settings or widescreen mode
  4. On talk pages, when the "Latest comment" links are tapped, Parsoid also collapses the section in the background (so the links don't work)

On article pages, when the section edit buttons are tapped, Parsoid also collapses the section in the background

Oh snap. I just saw this too: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1113238
This is a regression caused by the patch we just merged on T376048. I posted the fix there.

On article pages, when sections are collapsed, old parser hides the section edit buttons, but Parsoid does not

I captured this in https://phabricator.wikimedia.org/T384408

On talk pages, old parser always collapses all sections, but Parsoid may expand them according to user settings or widescreen mode
On talk pages, when the "Latest comment" links are tapped, Parsoid also collapses the section in the background (so the links don't work)

I'll defer to editing team on these ones. For the latter sounds like ev.stopPropagation needs to be called as well.

On talk pages, old parser always collapses all sections, but Parsoid may expand them according to user settings or widescreen mode

This is now filed as T401852, and being worked on.

All of the other issues I noted in T269499#10482448 have been resolved.