ParserCache should use CachedBagOStuff
Closed, ResolvedPublic
Actions

Description

Getting entries from ParserCache is quick, but on every page view we seem to do it at least twice. We need to wrap the provided BagOStuff into the CachedBagOStuff for ParserCache to introduce another layer of caching. The cached bag should be limited to some small number of entries - we don't want or need to support caching in-memory for use-cases which enumerates ParserOutputs.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+6 -0	ParserCache: Instrument CachedBagOStuff to understand dupe fetches
	mediawiki/core	master	+15 -6	Make ParserCache use CachedBagOStuff

Customize query in gerrit

Related Objects

Mentioned In: T277829: Understand or mitigate duplicate ParserCache fetches in the same request
T270228: "Error: Unsupported operand types" from ParserOptionsTest::testMatches on php74

Event Timeline

Pchelolo created this task.Dec 7 2020, 3:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2020, 3:25 PM

Change 646739 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make ParserCache use CachedBagOStuff

https://gerrit.wikimedia.org/r/646739

gerritbot added a project: Patch-For-Review.Dec 7 2020, 3:35 PM

Pchelolo moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.Dec 7 2020, 3:36 PM

Pchelolo added a project: MediaWiki-Parser.

Change 646739 merged by jenkins-bot:
[mediawiki/core@master] Make ParserCache use CachedBagOStuff

https://gerrit.wikimedia.org/r/646739

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 11 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2020, 10:10 PM

Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Dec 14 2020, 5:11 PM

Krinkle mentioned this in T270228: "Error: Unsupported operand types" from ParserOptionsTest::testMatches on php74.Dec 16 2020, 3:46 AM

Pchelolo closed this task as Resolved.Dec 17 2020, 9:35 PM

Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.

Change 671357 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] ParserCache: Instrument CachedBagOStuff to understand dupe fetches

https://gerrit.wikimedia.org/r/671357

gerritbot added a project: Patch-For-Review.Mar 13 2021, 1:43 AM

Change 671357 merged by jenkins-bot:
[mediawiki/core@master] ParserCache: Instrument CachedBagOStuff to understand dupe fetches

https://gerrit.wikimedia.org/r/671357

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Mar 15 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2021, 5:10 PM

Krinkle mentioned this in T277829: Understand or mitigate duplicate ParserCache fetches in the same request.Mar 19 2021, 1:03 AM