InvalidArgumentException when requesting Special:EntityData with Sense or Form ID (The given ID does not refer to an entity of type lexeme)
Closed, ResolvedPublic8 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.20

message

The given ID does not refer to an entity of type lexeme

Impact

About 4 logstash events per day since the late UTC evening of December 4th, prior to that only sporadic occurrences. Affects both wmf.18 and wmf.20.

Notes

T195110: Special:EntityData throws an exception when called with a form id indicates that this used to work (or at least we fixed it once).

Special:EntityData?id=L1-S1&format=json (ID in query params instead of path) produces the same error.

This happens only for IDs of existing Senses and Forms – e.g. Special:EntityData/L1-S1000.json returns “not found” without crashing.

Acceptance criteria

it should work again
there is an integration test in Lexeme for this (probably add another test to LexemeSpecialEntityDataTest, which currently only requests Special:EntityData with a Lexeme ID)

Details

Request ID: X84-@ApAEJcAAoTSUtMAAABA
Request URL: https://www.wikidata.org/wiki/Special:EntityData/L1-S1.json

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/Content/EntityContentFactory.php(127): Wikibase\Repo\Content\EntityHandler->getTitleForId(Wikibase\Lexeme\Domain\Model\SenseId)
#1 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/Api/ResultBuilder.php(344): Wikibase\Repo\Content\EntityContentFactory->getTitleForId(Wikibase\Lexeme\Domain\Model\SenseId)
#2 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/Api/ResultBuilder.php(308): Wikibase\Repo\Api\ResultBuilder->addPageInfoToRecord(array, Wikibase\Lib\Store\EntityRevision)
#3 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(397): Wikibase\Repo\Api\ResultBuilder->addEntityRevision(string, Wikibase\Lib\Store\EntityRevision)
#4 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(425): Wikibase\Repo\LinkedData\EntityDataSerializationService->generateApiResult(Wikibase\Lib\Store\EntityRevision, ApiFormatJson)
#5 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(155): Wikibase\Repo\LinkedData\EntityDataSerializationService->getApiSerialization(Wikibase\Lib\Store\EntityRevision, ApiFormatJson)
#6 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(521): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, NULL)
#7 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(267): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\Lexeme\Domain\Model\SenseId, integer)
#8 /srv/mediawiki/php-1.36.0-wmf.20/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(115): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#9 /srv/mediawiki/php-1.36.0-wmf.20/includes/specialpage/SpecialPage.php(645): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#10 /srv/mediawiki/php-1.36.0-wmf.20/includes/specialpage/SpecialPageFactory.php(1402): SpecialPage->run(string)
#11 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(945): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.36.0-wmf.20/includes/MediaWiki.php(548): MediaWiki->main()
#14 /srv/mediawiki/php-1.36.0-wmf.20/index.php(53): MediaWiki->run()
#15 /srv/mediawiki/php-1.36.0-wmf.20/index.php(46): wfIndexMain()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseLexeme	master	+62 -2	Add test for Special:EntityData with Sense/Form ID
	mediawiki/extensions/Wikibase	master	+40 -15	Avoid using EntityContentFactory as EntityTitleLookup

Customize query in gerrit

Related Objects

Mentioned In: T276439: Make EntityContentFactory not implement EntityTitleStoreLookup (and EntityIdLookup)
T272804: Entity JSON for Senses and Forms lacks "type" key
T264801: 1.36.0-wmf.21 deployment blockers
Mentioned Here: T145712: Use RDF statement counts from entity data, not page props ( wikibase:identifiers, wikibase:statements and wikibase:sitelinks )
rEWBAbbdd678624cd: Calculate page props on-the-fly during RDF dump
T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException
T264801: 1.36.0-wmf.21 deployment blockers
T195110: Special:EntityData throws an exception when called with a form id

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 7 2020, 4:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2020, 4:58 PM

Lucas_Werkmeister_WMDE added projects: Regression, Wikidata Lexicographical data.Dec 7 2020, 4:59 PM

WMDE-leszek added a subscriber: WMDE-leszek.Dec 7 2020, 5:02 PM

Lucas_Werkmeister_WMDE merged a task: T269650: InvalidArgumentException on Special:EntityData for existing senses.Dec 8 2020, 10:16 AM

Lucas_Werkmeister_WMDE mentioned this in T264801: 1.36.0-wmf.21 deployment blockers.

Lucas_Werkmeister_WMDE added a subscriber: DannyS712.

Krinkle moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.Dec 9 2020, 7:50 PM

Still happening in wmf.21

Mentioned in SAL (#wikimedia-operations) [2020-12-09T20:18:10Z] <twentyafterfour> wmf.21 looks good on group1 wikis. Still seeing T269603 but not at an increased rate. (refs T264801)

Something similar happened earlier in the year for EntityPage T200906: Special:EntityPage for form ID or sense ID results in InvalidArgumentException

Michael updated the task description. (Show Details)Dec 15 2020, 11:22 AM

Prio Notes: Started of split 3,4,11,15. We believe it was recently broken and likely easy to fix quickly we pushed it toward the top of the list

Logstash indicates this is new in wmf.18.

• Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Dec 15 2020, 1:06 PM

Lucas_Werkmeister_WMDE set the point value for this task to 8.Dec 15 2020, 2:41 PM

noarave moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Dec 16 2020, 9:18 AM

noarave edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 16 2020, 9:48 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 16 2020, 9:52 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Dec 16 2020, 10:15 AM

Lucas_Werkmeister_WMDE claimed this task.Jan 20 2021, 3:40 PM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

This turns out to be due to rEWBAbbdd678624cd: Calculate page props on-the-fly during RDF dump (for T145712). Let’s see if I can figure out how to fix it…

Okay, the issue is that the ResultBuilder now has an entityTitleLookup that is an EntityContentFactory, which used to be a TypeDispatchingEntityTitleStoreLookup that would dispatch to a specific SenseTitleStoreLookup. In other words – that change merged the EntityTitleLookup service with the EntityContentFactory service, since EntityContentFactory implements EntityTitleLookup, but in fact we need a better EntityTitleLookup.

Change 657550 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Avoid using EntityContentFactory as EntityTitleLookup

https://gerrit.wikimedia.org/r/657550

gerritbot added a project: Patch-For-Review.Jan 21 2021, 11:19 AM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 21 2021, 11:19 AM

LucasWerkmeister mentioned this in T272804: Entity JSON for Senses and Forms lacks "type" key.Jan 24 2021, 4:49 PM

Change 658245 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Add test for Special:EntityData with Sense/Form ID

https://gerrit.wikimedia.org/r/658245

Restricted Application added a project: wdwb-tech. · View Herald TranscriptJan 25 2021, 11:43 AM

Change 657550 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Avoid using EntityContentFactory as EntityTitleLookup

https://gerrit.wikimedia.org/r/657550

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 25 2021, 12:50 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 25 2021, 1:00 PM

Change 658245 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add test for Special:EntityData with Sense/Form ID

https://gerrit.wikimedia.org/r/658245

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2021, 1:10 PM

• Addshore edited projects, added wdwb-tech (legacy-backlog); removed wdwb-tech.Jan 25 2021, 2:04 PM

• Addshore moved this task from Incoming to Active on the wdwb-tech (legacy-backlog) board.

Will be deployed this week.
Can then be verified with the example in the description

This will now be deployed this week (It's in .28), .27 is still currently deployed and .29 is going out this week.

\o/

Lucas_Werkmeister_WMDE mentioned this in T276439: Make EntityContentFactory not implement EntityTitleStoreLookup (and EntityIdLookup).Mar 4 2021, 11:19 AM

	F33946262: Screenshot_2020-12-15 mediawiki-errors - Kibana.png
	Dec 15 2020, 11:47 AM

InvalidArgumentException when requesting Special:EntityData with Sense or Form ID (The given ID does not refer to an entity of type lexeme)Closed, ResolvedPublic8 Estimated Story PointsPRODUCTION ERRORActions