Page MenuHomePhabricator

mediawiki.skinning.content.externallinks is deprecated
Open, Needs TriagePublic

Description

The mediawiki.skinning.content.externallinks module is deprecated.

Impacted skins should use ResourceLoaderSkinModule following the example in Monobook

If no action is taken the module will eventually be removed and styles for icons that show up against links will no longer function in the skin.

Also: https://github.com/femiwiki/FemiwikiSkin/issues/210

Sign off steps

When resolving this ticket, please create a task for removing the module in core.

Event Timeline

Change 647359 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/BlueSky@master] Use skin features for external links and junk

https://gerrit.wikimedia.org/r/647359

Change 647359 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Use skin features for external links and junk

https://gerrit.wikimedia.org/r/647359

Change 647848 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/GreyStuff@master] Use newfangled stuff

https://gerrit.wikimedia.org/r/647848

Change 647848 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Use newfangled stuff

https://gerrit.wikimedia.org/r/647848

Change 649769 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

Change 649769 merged by jenkins-bot:
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

Change 650274 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Change 650274 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Change 673104 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Anisa@master] Use updated/core wodgits and bump required mw version to 1.35

https://gerrit.wikimedia.org/r/673104

Isarra added a subscriber: Isarra.

Not removing this from Anisa yet after all, as the replacement apparently isn't available in 1.35, and Anisa is still targeting 1.35 and not 1.36... is this still only deprecated as of an unreleased version, or something?

Frankly it's probably gonna have to go back into branches for a whole lot of skins anyway given 1.35 is the LTS, ugggghh.

Duuur I'm an idiot, I just need to copy the 1.35 fix out of timeless, huh.

Sorry about that, it turns out some of us are just drunk and sleep deprived and that doesn't result in the most meaningful testing...