Pick a sentence: Disable "Apply translation" button until machine translation is fetched
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	ngkountas
	Dec 8 2020, 2:30 PM

Description

"Apply translation" button is always enabled inside "Pick a sentence" screen. That enables user to click it, even if proposed MT has not yet been loaded, leading to unexpected behaviour.

Fix: Disable "Apply translation" button when proposed MT is being loaded.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Pick a sentence: Disable "Apply translation" button until MT fetched	mediawiki/extensions/ContentTranslation	master	+21 -5

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T243495 [Epic] Support for Section Translation
Open		None	T251551 Section Translation Editor: Pick a sentence
Resolved	BUG REPORT	ngkountas	T269679 Pick a sentence: Disable "Apply translation" button until machine translation is fetched

Event Timeline

ngkountas created this task.Dec 8 2020, 2:30 PM

ngkountas removed a project: Epic.

ngkountas moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2020-October-December) board.

Also referred in T267307

ngkountas mentioned this in T267307: Section translation: Prefetch sentence translations .Dec 8 2020, 2:33 PM

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2020-October-December) board.Dec 8 2020, 2:54 PM

Change 646999 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] Pick a sentence: Disable "Apply translation" button until MT fetched

https://gerrit.wikimedia.org/r/646999

gerritbot added a project: Patch-For-Review.Dec 8 2020, 3:02 PM

Jsmile0209 subscribed.Dec 8 2020, 3:15 PM

Change 646999 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Pick a sentence: Disable "Apply translation" button until MT fetched

https://gerrit.wikimedia.org/r/646999

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.22; 2020-12-15); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Dec 14 2020, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 7:10 AM

Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.Dec 16 2020, 12:43 PM

ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2020-October-December) board.Dec 17 2020, 4:59 AM

Pginer-WMF triaged this task as Medium priority.Dec 18 2020, 11:06 AM

• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2020-October-December) board.Dec 18 2020, 12:00 PM

Pginer-WMF closed this task as Resolved.Dec 18 2020, 2:42 PM