Write tests for WikibasePingback class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ItamarWMDE
	Dec 9 2020, 11:31 AM

Description

Since the WikibasePingback class was directly copied from the Pingack class in core, and no tests were written for the original class it, it is required to write unit tests for it.

Hints

Some tests were already added in WikibasePingbackTests.php

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	pingback: add more tests, inject requestfactory	mediawiki/extensions/Wikibase	master	+107 -36

Customize query in gerrit

Event Timeline

ItamarWMDE created this task.Dec 9 2020, 11:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2020, 11:31 AM

• toan claimed this task.Dec 9 2020, 1:31 PM

• toan moved this task from Backlog to Doing on the Wikibase Pingback board.Dec 9 2020, 1:46 PM

Change 647255 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] add more tests, inject requestfactory

https://gerrit.wikimedia.org/r/647255

gerritbot added a project: Patch-For-Review.Dec 9 2020, 2:49 PM

• toan moved this task from Doing to Peer Review on the Wikibase Pingback board.Dec 9 2020, 3:47 PM

ItamarWMDE moved this task from Peer Review to Done on the Wikibase Pingback board.Dec 11 2020, 7:52 AM

Change 647255 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] pingback: add more tests, inject requestfactory

https://gerrit.wikimedia.org/r/647255

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 11 2020, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2020, 8:10 PM