Page MenuHomePhabricator

link-in-logs not redirecting properly for private logs
Closed, ResolvedPublicBUG REPORT

Description

Refs.: T207562: Implement "links-in-logs" user script in MediaWiki itself

Steps to reproduce:

  1. Be logged-in to an account with the appropriate permissions (suppresionlog)
  2. Browse to the private Special:Log/suppress of your wiki and select a random log entry there.
  3. Get a link "permanent link" for such log entry such as https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=39174010

Actual results:
https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=39174010 leads you to the "All public logs" tab of Special:Log but no entry matching that logid is displayed to me even when I have the appropriate permissions to see private log entries.

Expected results:
Log entry matching that logid be displayed, if you have the appropriate permissions of course.

Software details:
MediaWiki 1.36.0-wmf.20 (027c913)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2020, 3:26 PM
Base added a subscriber: Base.Dec 10 2020, 11:16 AM

Oh hey, was literally just coming to report this; patch coming momentarily

Change 649691 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] LogPager: if log_id is set, don't use public exclude clause

https://gerrit.wikimedia.org/r/649691

DannyS712 moved this task from To Triage to Not ready to announce on the User-notice board.

Change 649691 merged by jenkins-bot:
[mediawiki/core@master] LogPager: if log_id is set, don't use public exclude clause

https://gerrit.wikimedia.org/r/649691

JJMC89 closed this task as Resolved.Wed, Dec 30, 9:35 PM
JJMC89 assigned this task to DannyS712.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptWed, Dec 30, 9:35 PM