Page MenuHomePhabricator

Improve error handling in AbuseFilterParser
Open, Needs TriagePublic

Description

Right now the parser can only:

  • Report a single error at a time
  • And it does so by throwing an AFPException

Two things that can be improved:

  • Report more than one error at the same time (not sure if this is always possible, given the current validation and filter syntax)
  • Report non-fatal errors; these would likely only be shown while validating the filter client-side (T187686)

Event Timeline

Note: this should be done once the old parser is removed.

Change 650530 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Return warnings from the parser, add warning for catch-all regexps

https://gerrit.wikimedia.org/r/650530

Change 650530 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Return warnings from the parser, add warning for catch-all regexps

https://gerrit.wikimedia.org/r/650530