Page MenuHomePhabricator
Create Task
Maniphest T269770

Improve error handling in AbuseFilterParser
Open, Needs TriagePublic
Actions

Description

Right now the parser can only:

  • Report a single error at a time
  • And it does so by throwing an AFPException

Two things that can be improved:

  • Report more than one error at the same time (not sure if this is always possible, given the current validation and filter syntax)
  • Report non-fatal errors; these would likely only be shown while validating the filter client-side (T187686)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Return warnings from the parser, add warning for catch-all regexpsDaimona Eaytoymediawiki/extensions/AbuseFiltermaster+137 -39
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Dec 9 2020, 4:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2020, 4:08 PM
Daimona added a comment.Dec 12 2020, 5:23 PM

Note: this should be done once the old parser is removed.

gerritbot added a comment.Dec 18 2020, 4:55 PM

Change 650530 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Return warnings from the parser, add warning for catch-all regexps

https://gerrit.wikimedia.org/r/650530

gerritbot added a project: Patch-For-Review.Dec 18 2020, 4:55 PM
gerritbot added a comment.Dec 18 2020, 8:26 PM

Change 650530 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Return warnings from the parser, add warning for catch-all regexps

https://gerrit.wikimedia.org/r/650530

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 18 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 18 2020, 9:10 PM
Aklapper added a comment.Jul 21 2021, 10:25 AM
In T269770#6686585, @Daimona wrote:

Note: this should be done once the old parser is removed.

Hmm, that means when using Parsoid only...?

Daimona added a comment.Jul 21 2021, 11:19 AM
In T269770#7226874, @Aklapper wrote:
In T269770#6686585, @Daimona wrote:

Note: this should be done once the old parser is removed.

Hmm, that means when using Parsoid only...?

No, I was referring to the (old) AbuseFilter parser. Which has been removed since then.

Daimona mentioned this in T237610: Syntax validation should flag unused variables.Sep 1 2021, 10:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits