Increase test coverage for GeoIP2 information [M]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Dec 9 2020, 4:34 PM

Description

User testing is going to be difficult, since we don't currently have all of MaxMind's data files available to the Beta Cluster, or even in production. To make up for this, we should be rigorous with our unit test coverage.

This task is for ensuring that our unit tests cover our usage of the geoip2 Reader API and the Model classes' APIs (e.g. City.php, Asn.php, etc). This may involve refactoring GeoIp2InfoRetriever.

We may also be able to make use of Maxmind's test databases for integration tests.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Increase test coverage for GeoIP2 information	mediawiki/extensions/IPInfo	master	+114 -30
Increase test coverage for GeoIP2 information	mediawiki/extensions/IPInfo	master	+66 -20
Increase test coverage for GeoIP2 information	mediawiki/extensions/IPInfo	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEIPIf0d9bb1975a0: Increase test coverage for GeoIP2 information
T260822: Security review of IP Info extension

Event Timeline

Tchanders created this task.Dec 9 2020, 4:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2020, 4:34 PM

ARamirez_WMF set the point value for this task to 3.Dec 9 2020, 4:38 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

Tchanders updated the task description. (Show Details)Dec 9 2020, 5:19 PM

Aklapper added a project: Test-Coverage.Dec 10 2020, 11:00 AM

Tchanders renamed this task from Increase unit test coverage for GeoIP2 information to Increase test coverage for GeoIP2 information.Dec 23 2020, 7:29 PM

Tchanders updated the task description. (Show Details)

Tchanders mentioned this in T260822: Security review of IP Info extension.

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Feb 3 2021, 5:18 PM

ARamirez_WMF edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

ARamirez_WMF moved this task from The Letter Song to Cards ready for development on the Anti-Harassment-Team board.Feb 11 2021, 5:42 PM

ARamirez_WMF edited projects, added Anti-Harassment-Team; removed Anti-Harassment-Team (The Letter Song).

Niharika moved this task from Cards ready for development to Triage/To be Estimated on the Anti-Harassment-Team board.Mar 24 2021, 12:33 PM

A good first start would be to either:

Make MediaWiki\Extensions\IPInfo\InfoRetriever\GeoIP2InfoRetriever::getReader() protected
Extract a ReaderFactory class that we inject into GeoIP2InfoRetriever at construction time

In either case, we can then make assertions about which readers are being requested and what GeoIP2InfoRetriever returns when the requested reader behaves a particular way.

This is an involved task but is a good one to familiarise yourself with (unit) testing and PHPUnit.

ARamirez_WMF renamed this task from Increase test coverage for GeoIP2 information to Increase test coverage for GeoIP2 information [M].Oct 6 2021, 4:34 PM

ARamirez_WMF removed the point value 3 for this task.

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.

• TThoabala claimed this task.Oct 7 2021, 3:21 PM

Niharika edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.Oct 7 2021, 10:41 PM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Oct 11 2021, 6:34 PM

Change 731259 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):