Page MenuHomePhabricator

Class SpecialUpload - no interface for manipulating upload summary/mComment
Closed, ResolvedPublic


Author: razqubik

Since 1.16 many members of this class were set to scope "protected".

The description of hook UploadForm:BeforeProcessing says:"Called just before the file data (for example description) are processed, so extensions have a chance to manipulate them."

As I have not found any way to manipulate e.g. mComment I feel this is a bug to be addressed.

(One of my extensions actively manipulated the comments till 1.15...)

Kind regards

Version: 1.16.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport set Reference to bz24981.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

Assigning to me.

Easiest is probably to make the variables public again for backwardscompatibility.

ayg wrote:

r57868 was the problem. It changed loads of fields to protected for no apparent reason. Fixed in r71903, backported to the 1.16 branch in r71904, added forgotten RELEASE-NOTES in r71905. So this should be part of 1.16.1 when that's released, as well as 1.17. For now you can manually patch the file, since you know that the changes won't be overwritten when you upgrade.

ayg wrote:

(mid-air collision, oh well :) )

Bryan.TongMinh wrote:

*** Bug 25833 has been marked as a duplicate of this bug. ***