Page MenuHomePhabricator
Create Task
Maniphest T269869

rename ParserCacheFactory::getInstance to getParserCache
Closed, ResolvedPublic
Actions

Description

We want to be able to return different kinds of caches from ParserCacheFactory, so having a method called getInstance() is odd.

Details

SubjectRepoBranchLines +/-
Remove ParserCacheFactory::getInstancemediawiki/coremaster+1 -14
Change ParserCacheFactory::getInstance to ::getParserCachemediawiki/extensions/FlaggedRevsmaster+2 -2
Customize query in gerrit

Event Timeline

daniel created this task.Dec 10 2020, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 5:17 PM
• Pchelolo moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.Dec 14 2020, 5:12 PM
gerritbot added a comment.Dec 15 2020, 1:04 AM

Change 649476 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/FlaggedRevs@master] Change ParserCacheFactory::getInstance to ::getParserCache

https://gerrit.wikimedia.org/r/649476

gerritbot added a project: Patch-For-Review.Dec 15 2020, 1:04 AM

Change 649477 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove ParserCacheFactory::getInstance

https://gerrit.wikimedia.org/r/649477

• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Dec 15 2020, 1:06 AM
gerritbot added a comment.Dec 15 2020, 6:33 PM

Change 649476 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Change ParserCacheFactory::getInstance to ::getParserCache

https://gerrit.wikimedia.org/r/649476

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 15 2020, 7:00 PM
gerritbot added a comment.Dec 15 2020, 7:25 PM

Change 649477 merged by jenkins-bot:
[mediawiki/core@master] Remove ParserCacheFactory::getInstance

https://gerrit.wikimedia.org/r/649477

• Pchelolo closed this task as Resolved.Dec 15 2020, 7:54 PM
• Pchelolo moved this task from Waiting for Review to Done on the Platform Team Workboards (Green) board.
Maintenance_bot removed a project: Patch-For-Review.Dec 15 2020, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits